Commit fec1c3f
committed
fix two contracts that still promised the zero-crossing cache, and a miscount of my own
CodeRabbit review on #85, both findings real and both mine.
1. I re-pinned the TEST and left two JAVADOC CONTRACTS asserting the
behaviour the pin had just contradicted. `Mask.java` said every
materializeRows() after the first is "an in-process segment access with no
further crossing at all"; `Graph.java` said "a one-time describe, then zero
further crossings for repeated calls". Both describe the pure cache that
preceded the epoch re-validation. Corrected in place with the struck text
kept, and stating what the cache DOES still buy, which is the part worth
keeping: the words are never re-fetched and the population is never
re-scanned, because lgj_mask_describe fills a descriptor and does no work
over the rows. The cost is constant per call, not zero after the first.
Worth naming plainly: the previous commit's message argued that a
doc-comment claim is not a behaviour, and then left two doc comments
claiming the opposite of the behaviour it had just measured. No test could
catch it, because a javadoc contract has none -- review did.
2. `BricksQuery.sumBy()` said BricksAuthTest pins the cost across "two group
counts". It uses three: 1, Orders.REGIONS, and 4 * Orders.REGIONS. My own
miscount, in the same paragraph that argues the group-count arm is what
makes the claim falsifiable.
Gates unchanged and re-run: core 612/612, bricks 70/70, graph 68/68, trades
12/12 + 3/3.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG1 parent 555e69a commit fec1c3f
3 files changed
Lines changed: 26 additions & 9 deletions
File tree
- consumers
- bricks/src/main/java/com/adaworldapi/bricks
- graph/src/main/java/com/adaworldapi/graph
- java/src/main/java/com/adaworldapi/lancegraph
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
| 108 | + | |
108 | 109 | | |
109 | 110 | | |
110 | 111 | | |
| |||
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
219 | | - | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
220 | 223 | | |
221 | 224 | | |
222 | 225 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
49 | 62 | | |
50 | 63 | | |
51 | 64 | | |
| |||
0 commit comments