[EMCAL-610] Fix segfault in Raw creator

- Fix buffer overrun in findBunches leading to segfault
- In getting online ID (SRU ID in supermodule had to be
   scaled with the number of supermodules in order to get
   the DDL ID)
- Convert trailer size as size in 32bit words to size in byte in
   carryOverMethod in order to calculate properly the
   payload size

Author: mfasDa

Detectors/EMCAL/base/include/EMCALBase/RCUTrailer.h

@@ -161,8 +161,8 @@ class RCUTrailer
  private:
   int mRCUId = -1;                    ///< current RCU identifier
   unsigned char mFirmwareVersion = 0; ///< RCU firmware version
-  unsigned int mTrailerSize = 0;      ///< Size of the trailer
-  unsigned int mPayloadSize = 0;      ///< Size of the payload
+  unsigned int mTrailerSize = 0;      ///< Size of the trailer (in number of 32 bit words)
+  unsigned int mPayloadSize = 0;      ///< Size of the payload (in nunber of 32 bit words)
   unsigned int mFECERRA = 0;          ///< contains errors related to ALTROBUS transactions
   unsigned int mFECERRB = 0;          ///< contains errors related to ALTROBUS transactions
   unsigned short mERRREG2 = 0;        ///< contains errors related to ALTROBUS transactions or trailer of ALTRO channel block

Detectors/EMCAL/base/src/Mapper.cxx

@@ -115,6 +115,6 @@ Mapper& MappingHandler::getMappingForDDL(int ddl)
 
 std::ostream& o2::emcal::operator<<(std::ostream& stream, const Mapper::ChannelID& channel)
 {
-  stream << "Row " << channel.mRow << ", Column " << channel.mColumn << ", type " << o2::emcal::channelTypeToString(channel.mChannelType);
+  stream << "Row " << static_cast<int>(channel.mRow) << ", Column " << static_cast<int>(channel.mColumn) << ", type " << o2::emcal::channelTypeToString(channel.mChannelType);
   return stream;
 }

Detectors/EMCAL/simulation/src/RawWriter.cxx

@@ -152,6 +152,7 @@ bool RawWriter::processNextTrigger()
     // register output data
     auto ddlid = srucont.mSRUid;
     auto [crorc, link] = getLinkAssignment(ddlid);
+    LOG(DEBUG1) << "Adding payload with size " << payload.size() << " (" << payload.size() / 4 << " ALTRO words)";
     mRawWriter->addData(ddlid, crorc, link, 0, mCurrentTrigger->getBCData(), payload);
   }
   mCurrentTrigger++;
@@ -162,30 +163,32 @@ std::vector<AltroBunch> RawWriter::findBunches(const std::vector<o2::emcal::Digi
 {
   std::vector<AltroBunch> result;
   AltroBunch* currentBunch = nullptr;
-  int starttime = 0;
-  for (auto ien = channelDigits.size() - 1;; ien--) {
-    auto dig = channelDigits[ien];
+  // Digits in ALTRO bunch in time-reversed order
+  int itime;
+  for (itime = channelDigits.size() - 1; itime >= 0; itime--) {
+    auto dig = channelDigits[itime];
     if (!dig) {
-      starttime++;
       continue;
     }
-    int adc = dig->getEnergy() / constants::EMCAL_ADCENERGY; /// conversion Energy <-> ADC := 16 MeV/ADC
+    int adc = dig->getAmplitudeADC();
     if (adc < mPedestal) {
       // Stop bunch
+      // Set the start time to the time sample of previous (passing) digit
+      currentBunch->mStarttime = itime + 1;
       currentBunch = nullptr;
-      starttime++;
       continue;
     }
     if (!currentBunch) {
       // start new bunch
       AltroBunch bunch;
-      bunch.mStarttime = starttime;
       result.push_back(bunch);
       currentBunch = &(result.back());
     }
     currentBunch->mADCs.emplace_back(adc);
-    starttime++;
   }
+  // if we have a last bunch set time start time to the time bin of teh previous digit
+  if (currentBunch)
+    currentBunch->mStarttime = itime + 1;
   return result;
 }
 
@@ -197,19 +200,19 @@ std::tuple<int, int, int> RawWriter::getOnlineID(int towerID)
   auto etaphishift = mGeometry->ShiftOfflineToOnlineCellIndexes(supermoduleID, std::get<0>(etaphi), std::get<1>(etaphi));
   int row = std::get<0>(etaphishift), col = std::get<1>(etaphishift);
 
-  int sruID = -1;
+  int ddlInSupermoudel = -1;
   if (0 <= row && row < 8)
-    sruID = 0; // first cable row
+    ddlInSupermoudel = 0; // first cable row
   else if (8 <= row && row < 16 && 0 <= col && col < 24)
-    sruID = 0; // first half;
+    ddlInSupermoudel = 0; // first half;
   else if (8 <= row && row < 16 && 24 <= col && col < 48)
-    sruID = 1; // second half;
+    ddlInSupermoudel = 1; // second half;
   else if (16 <= row && row < 24)
-    sruID = 1; // third cable row
+    ddlInSupermoudel = 1; // third cable row
   if (supermoduleID % 2 == 1)
-    sruID = 1 - sruID; // swap for odd=C side, to allow us to cable both sides the same
+    ddlInSupermoudel = 1 - ddlInSupermoudel; // swap for odd=C side, to allow us to cable both sides the same
 
-  return std::make_tuple(sruID, row, col);
+  return std::make_tuple(supermoduleID * 2 + ddlInSupermoudel, row, col);
 }
 
 std::tuple<int, int> RawWriter::getLinkAssignment(int ddlID)
@@ -284,7 +287,7 @@ int RawWriter::carryOverMethod(const header::RDHAny* rdh, const gsl::span<char>
   gsl::span<const uint32_t> payloadwords(reinterpret_cast<const uint32_t*>(data.data()), data.size() / sizeof(uint32_t));
   auto rcutrailer = RCUTrailer::constructFromPayloadWords(payloadwords);
 
-  int sizeNoTrailer = maxSize - rcutrailer.getTrailerSize();
+  int sizeNoTrailer = maxSize - rcutrailer.getTrailerSize() * sizeof(uint32_t);
   // calculate payload size for RCU trailer:
   // assume actualsize is in byte
   // Payload size is defined as the number of 32-bit payload words