[PWGEM] Add configurable for min. number of photons in EOI #33717
jokonigAnnotations
6 errors, 1 warning, and 2 notices
|
O2 linter
Process completed with exit code 1.
|
|
O2 linter result
Issues have been found.
|
|
[name/workflow-file]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
[name/o2-task]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
[name/o2-task]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L197
Device names filter-eoi and filter-eo-i generated from the specified task name filter-eoi and from the struct name filterEoI, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to FilterEoi and removing TaskName.
|
|
[magic-number]:
PWGEM/Dilepton/TableProducer/filterEoI.cxx#L120
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: thollander/actions-comment-pull-request@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|