Skip to content

Commit 10bb454

Browse files
committed
more linter errors fixed
1 parent 9cadd28 commit 10bb454

4 files changed

Lines changed: 136 additions & 129 deletions

File tree

PWGDQ/Core/CutsLibrary.cxx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7973,9 +7973,10 @@ o2::aod::dqmlcuts::BdtScoreConfig o2::aod::dqmlcuts::GetBdtScoreCutsAndConfigFro
79737973
binaryCfg.cutsMl = makeLabeledCutsMl(cutsMl, labelsFlatBin, labelsClass);
79747974

79757975
return binaryCfg;
7976-
7977-
// MultiClass
7978-
} else if (typeStr == "MultiClass") {
7976+
}
7977+
7978+
// MultiClass
7979+
if (typeStr == "MultiClass") {
79797980
dqmlcuts::MultiClassBdtScoreConfig multiCfg;
79807981
multiCfg.inputFeatures = namesInputFeatures;
79817982
multiCfg.onnxFiles = onnxFileNames;

PWGDQ/Core/MCSignalLibrary.cxx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2124,10 +2124,10 @@ std::vector<MCSignal*> o2::aod::dqmcsignals::GetMCSignalsFromJSON(const char* js
21242124
if (!ValidateJSONMCSignal(&signal, sigName)) {
21252125
LOG(fatal) << "MCSignal JSON not properly defined for " << sigName << ". Skipping";
21262126
continue;
2127-
} else {
2128-
LOG(debug) << "MCSignal validated";
21292127
}
21302128

2129+
LOG(debug) << "MCSignal validated";
2130+
21312131
// Get the signal title
21322132
const char* title = (signal.HasMember("title") ? signal.FindMember("title")->value.GetString() : "");
21332133
LOG(info) << "Title is: " << title;
@@ -2175,7 +2175,7 @@ std::vector<MCSignal*> o2::aod::dqmcsignals::GetMCSignalsFromJSON(const char* js
21752175
}
21762176
}
21772177

2178-
if (prongs.size() == 0) {
2178+
if (prongs.empty()) {
21792179
LOG(fatal) << "No prongs were defined for this MCSignal!";
21802180
return signals;
21812181
}

PWGDQ/Tasks/DalitzSelection.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,7 @@ struct DalitzSelection {
679679
uint32_t bitMask = (static_cast<uint32_t>(1) << 8);
680680
fMixingEvent->ClearFilteringMask(bitMask);
681681

682-
for (auto& poolEvent : pool.events) { // o2-linter disable=const-ref-in-for-loop (false positive, it cannot be made const since it is modified within the loop)
682+
for (auto& poolEvent : pool.events) { // o2-linter: disable=const-ref-in-for-loop (false positive, it cannot be made const since it is modified within the loop)
683683
if ((poolEvent.filteringMask & static_cast<uint32_t>(255)) == 0) {
684684
// all other bits have been erased, so we can also mark bit 8 for deletion
685685
poolEvent.filteringMask |= bitMask;

0 commit comments

Comments
 (0)