remove reinterpret_cast and add extra protections

Author: atavirag

PWGDQ/Macros/evalMchTrackingEfficiency.cxx

@@ -27,6 +27,7 @@
 
 #include <Rtypes.h>
 
+#include <iostream>
 #include <vector>
 
 double computeEfficiencyPerChamber(THnF* hnf, int iAxis, int iCh, double binLimits[2]);
@@ -46,8 +47,26 @@ void evalMchTrackingEfficiency(const char* inFile = "AnalysisResults.root", cons
 {
   // read ouput from the taskComputeMchEfficiency
   TFile* file = TFile::Open(inFile, "read");
-  TDirectoryFile* dir = reinterpret_cast<TDirectoryFile*>(file->Get("task-muon-mch-trk-efficiency"));
-  THnF* hHitsEtaPtPhi = reinterpret_cast<THnF*>(dir->Get("hHitsEtaPtPhi"));
+  if (!file || file->IsZombie()) {
+    std::cerr << "Cannot open input file: " << inFile << std::endl;
+    return;
+  }
+
+  TDirectoryFile* dir = nullptr;
+  file->GetObject("task-muon-mch-trk-efficiency", dir);
+
+  THnF* hHitsEtaPtPhi = nullptr;
+  if (dir) {
+    dir->GetObject("hHitsEtaPtPhi", hHitsEtaPtPhi);
+  } else {
+    std::cerr << "Directory task-muon-mch-trk-efficiency not found in file " << inFile << std::endl;
+    return;
+  }
+
+  if (!hHitsEtaPtPhi) {
+    std::cerr << "Histogram hHitsEtaPtPhi not found in directory." << std::endl;
+    return;
+  }
 
   // retrieve the eta/pt/phi axis binning configuration
   const int etaAx = 1, ptAx = 2, phiAx = 3;
@@ -274,7 +293,7 @@ double computeEfficiencyPerChamber(THnF* hnf, int iAxis, int iCh, double binLimi
   hnf->GetAxis(iAxis)->SetRangeUser(binLimits[0], binLimits[1]);
 
   // Project onto the Nhits axis
-  TH1F* htmp = reinterpret_cast<TH1F*>(hnf->Projection(0));
+  TH1D* htmp = hnf->Projection(0);
   double NhitPairing[16];
   for (int i = 0; i < 16; i++) {
     NhitPairing[i] = 0;
@@ -322,7 +341,7 @@ double computeEfficiencyPerChamber(THnF* hnf, const int iAxis[3], int iCh, doubl
   }
 
   // Project onto the Nhits axis
-  TH1F* htmp = reinterpret_cast<TH1F*>(hnf->Projection(0));
+  TH1D* htmp = hnf->Projection(0);
   double NhitPairing[16];
   for (int i = 0; i < 16; i++) {
     NhitPairing[i] = 0;