else after return, code quality

kaareendrup · kaareendrup · commit 7f67766be7b4 · 2026-07-22T16:17:13.000+02:00
diff --git a/PWGDQ/Tasks/jPsiMuonCorrelations.cxx b/PWGDQ/Tasks/jPsiMuonCorrelations.cxx
@@ -271,7 +271,6 @@ double getWeight(const double pT, const std::vector<double>& binsPT, const std::
   if (binEff == -1) {
     LOGF(warn, "pT value %f is outside the defined pT bins", pT);
     return 0.0;
-  } else {
-    return 1.0 / (efficiency[binEff] * (getRapidity(pT, etaMax) - getRapidity(pT, etaMin)));
   }
+  return 1.0 / (efficiency[binEff] * (getRapidity(pT, etaMax) - getRapidity(pT, etaMin)));
 }

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,6 @@ double getWeight(const double pT, const std::vector<double>& binsPT, const std::`
`271`	`271`	`if (binEff == -1) {`
`272`	`272`	`LOGF(warn, "pT value %f is outside the defined pT bins", pT);`
`273`	`273`	`return 0.0;`
`274`		`- } else {`
`275`		`- return 1.0 / (efficiency[binEff] * (getRapidity(pT, etaMax) - getRapidity(pT, etaMin)));`
`276`	`274`	`}`
	`275`	`+ return 1.0 / (efficiency[binEff] * (getRapidity(pT, etaMax) - getRapidity(pT, etaMin)));`
`277`	`276`	`}`