From 75f3beda817d33d1f2af69814182ab29525b8e48 Mon Sep 17 00:00:00 2001 From: Eric Pinxteren Date: Sun, 4 Oct 2026 10:30:15 +0200 Subject: [PATCH 1/2] fix: allow review to return to drill starting position Removed unnecessary check for parent node's FEN in disablePrevious condition. --- src/components/Openings/OpeningDrillSidebar.tsx | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/components/Openings/OpeningDrillSidebar.tsx b/src/components/Openings/OpeningDrillSidebar.tsx index cf3513e7..14d835b0 100644 --- a/src/components/Openings/OpeningDrillSidebar.tsx +++ b/src/components/Openings/OpeningDrillSidebar.tsx @@ -78,11 +78,8 @@ export const OpeningDrillSidebar: React.FC = ({ return } const atOpeningEnd = tree.currentNode === openingEndNode - const wouldLandOnOpeningEnd = - !!tree.currentNode?.parent && - tree.currentNode.parent.fen === openingEndNode.fen - if (atOpeningEnd || wouldLandOnOpeningEnd) return + if (atOpeningEnd) return tree.goToPreviousNode() } @@ -366,9 +363,7 @@ export const OpeningDrillSidebar: React.FC = ({ disableFlip={true} disablePrevious={ openingEndNode - ? tree.currentNode === openingEndNode || - (!!tree.currentNode?.parent && - tree.currentNode.parent.fen === openingEndNode.fen) + ? tree.currentNode === openingEndNode : false } embedded From ed6f67b0c9aaa82c2025d906152ea27ec4e0b8c6 Mon Sep 17 00:00:00 2001 From: Eric Pinxteren Date: Sun, 4 Oct 2026 10:32:46 +0200 Subject: [PATCH 2/2] style: keep drill back guard lint compliant Use a boolean expression for the disabled state of review navigation. --- src/components/Openings/OpeningDrillSidebar.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/Openings/OpeningDrillSidebar.tsx b/src/components/Openings/OpeningDrillSidebar.tsx index 14d835b0..f0385ab8 100644 --- a/src/components/Openings/OpeningDrillSidebar.tsx +++ b/src/components/Openings/OpeningDrillSidebar.tsx @@ -362,9 +362,7 @@ export const OpeningDrillSidebar: React.FC = ({ goToRootNode={customGoToRootNode} disableFlip={true} disablePrevious={ - openingEndNode - ? tree.currentNode === openingEndNode - : false + !!openingEndNode && tree.currentNode === openingEndNode } embedded />