From 8dfbf08dd7ad978d88a9778dfd40b7e0eca8ede5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ricardo=20Gro=C3=9F?= Date: Wed, 21 Oct 2026 11:03:04 +0200 Subject: [PATCH] chore: describe the branches as they are in the workflow comments The comments still described the release/10.x and net11 plan that #36 and #38 replaced. Drop the net11 triggers too: #38 dropped the branch. Closes #180 Co-Authored-By: Claude Opus 5.5 --- .github/workflows/dotnet.yml | 14 +++++++------- .github/workflows/nightly.yml | 6 +++--- .github/workflows/pr-hygiene.yml | 2 +- .github/workflows/release.yml | 2 +- CLAUDE.md | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 19807d7..821cc4f 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -1,7 +1,7 @@ -# Build and test on every push to main, a release branch or net11, and every PR into any of them. -# Two lines are supported from 11.0.0 on (CONTRIBUTING.md#branches-and-releases), and each branch -# that ships one needs the same checks as main's: release/10.x holds the LTS line once the v10.0.0 -# tag exists, and net11 holds the .NET 11 retarget and ships 11.0.0-preview.N until then. +# Build and test on every push to main or a release branch, and every PR into either. +# Two lines are supported (CONTRIBUTING.md#branches-and-releases), and each branch that ships one +# needs the same checks: release/5.x holds the 5.x LTS line, cut from the v5.5.0 tag, and main the +# SchemaKit line, which tags its 11.0.0-preview.N releases on main. # # Split into jobs on purpose: the unit suite and one integration job per database, which need # Docker for their PostgreSQL and SQL Server containers. @@ -26,9 +26,9 @@ name: .NET on: push: - branches: [ "main", "release/**", "net11" ] + branches: [ "main", "release/**" ] pull_request: - branches: [ "main", "release/**", "net11" ] + branches: [ "main", "release/**" ] workflow_dispatch: workflow_call: @@ -387,7 +387,7 @@ jobs: # The one required build check. Branch protection names this job and nothing else in this # workflow, so a new lane is a line in `needs` below rather than an edit to the protection of - # every protected branch (main, and release/5.x once it is cut). + # every protected branch (main and release/5.x). # # Required checks cannot do this themselves: GitHub reports a skipped job as Success, even on a # required check, whether it was skipped by its own condition or because a job it needs failed. diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 0862ce9..f9125f6 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -8,8 +8,8 @@ # # Two parts. `default-branch` calls dotnet.yml here, on the default branch, which is the only one a # schedule runs on. `release-lines` dispatches dotnet.yml on each release branch that exists, so -# that branch is tested by its own workflow and its own SDK (after the v5.5.0 cut, main is .NET 11 -# and release/5.x is .NET 10), and waits for the result. +# that branch is tested by its own workflow and its own SDK (release/5.x stays on .NET 10 when main +# moves to .NET 11, #38), and waits for the result. # # A failure opens an issue, or comments on the one already open, rather than relying on GitHub's # emails. Those reach only the user who last edited the cron line, and only under their personal @@ -41,7 +41,7 @@ concurrency: env: # The branches besides the default one that ship a supported line. A branch that does not exist - # yet is skipped with a notice, so release/5.x is covered from the night after it is cut. + # yet is skipped with a notice, so a new line is covered from the night after it is cut. RELEASE_LINES: release/5.x jobs: diff --git a/.github/workflows/pr-hygiene.yml b/.github/workflows/pr-hygiene.yml index 37e6bbc..1755466 100644 --- a/.github/workflows/pr-hygiene.yml +++ b/.github/workflows/pr-hygiene.yml @@ -15,7 +15,7 @@ name: PR hygiene on: pull_request: - branches: [ "main", "release/**", "net11" ] + branches: [ "main", "release/**" ] types: [ opened, edited, reopened, synchronize, labeled, unlabeled ] permissions: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e2decb7..a6ed235 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -361,7 +361,7 @@ jobs: # "Latest" is decided here rather than left to the API's default, which marks every new # release Latest. Two lines are supported from 11.0.0 on (CONTRIBUTING.md, "Branches and - # releases"), so this is the normal case, not an accident: a 10.x tag pushed once 11.0.0 + # releases"), so this is the normal case, not an accident: a 5.x tag pushed once 11.0.0 # exists is older than Latest and must not take it, or the repository's front page would # point every visitor at the LTS line. A preview (`11.0.0-preview.N`) is a prerelease and # never Latest. With no tag, `gh release view` shows the current Latest release, which is diff --git a/CLAUDE.md b/CLAUDE.md index 2d5b5f8..0358060 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -42,7 +42,7 @@ the build reports green. ## CI -`.github/workflows/dotnet.yml` runs on pushes and PRs to `main`, `release/**` and `net11`: the +`.github/workflows/dotnet.yml` runs on pushes and PRs to `main` and `release/**`: the unit suite, the integration suites (Docker; `Integration (PostgreSQL 18)` and `Integration (SQL Server 2022)`, one job each), then a pack job whose value is partly that packing *is* a check — a package declaring `PackageReadmeFile` without packing the file fails with