Skip to content

Commit 7289077

Browse files
committed
Fix 3 dangling reference drifts in SKILL.md
what: - study-repo-verification-patterns.md -> mature-repo-preservation.md (task table) - dependency-update-workflow.md -> review-checklist.md (task table) - Remove dangling reference to references/hermes-runtime-plugin-verification.md (paragraph is self-contained without it) why: These reference files were removed with the evals/research cleanup but the SKILL.md table and prose still pointed at them. At runtime, agents would be told to load nonexistent files — silent drift that degrades the skill.
1 parent f7c7c63 commit 7289077

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

skill/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,15 +134,15 @@ Classify the task so the skill loads only what is useful:
134134
| New project setup | `pyproject-template.md`, then `project-orientation.md` |
135135
| Existing project review | `review-checklist.md`, then task-specific files |
136136
| Mature repository / automation repo review | `mature-repo-preservation.md`, then `review-checklist.md`; if eval/benchmark runners are involved, also load `eval-benchmark-hardening.md` |
137-
| **Study/notes repo with custom verification** | `study-repo-verification-patterns.md` |
137+
| **Study/notes repo with custom verification** | `mature-repo-preservation.md` |
138138
| Type-hinting | `lint-format-typing-testing.md` (`mypy.md` is deferred) |
139139
| Test work | `lint-format-typing-testing.md` (`pytest.md` is deferred) |
140140
| Packaging/release | `pyproject-template.md` and `lint-format-typing-testing.md` (`packaging.md` deferred) |
141141
| Error handling/logging | `review-checklist.md` (`errors-and-logging.md` is deferred) |
142142
| CLI development | `pyproject-template.md` for entry points; for guidance on migrating CLI scripts from bash to Python (thin wrapper pattern, recognition criteria, reference sweep), see `shell-scripting` skill's "When to Migrate from Bash to Python" section | |
143143
| Migration from existing code | `project-orientation.md`; migration-specific reference is deferred |
144144
| General Python tooling (lint, format, type, test) | `lint-format-typing-testing.md` |
145-
| Dependency update (check versions, read changelogs, clean up stale CI workarounds) | `dependency-update-workflow.md` |
145+
| Dependency update (check versions, read changelogs, clean up stale CI workarounds) | `review-checklist.md` (dependency section) |
146146

147147
## Modern Baseline Defaults
148148

@@ -291,7 +291,7 @@ sed -n '<LINE_NUM>p' <file> | xxd | grep '5c'
291291

292292
Prefer project-native commands if present. Otherwise suggest the baseline.
293293

294-
**Hermes runtime/plugin edits:** If the edited Python lives under `~/.hermes/hermes-agent/` rather than a normal product checkout, do not stop at gateway restart or manual behavior inspection. Run syntax/lint checks against the changed runtime files, a relevant pytest subset, and a focused import/behavior probe from the Hermes runtime venv. See `references/hermes-runtime-plugin-verification.md` for the concrete pattern and reporting requirements.
294+
**Hermes runtime/plugin edits:** If the edited Python lives under `~/.hermes/hermes-agent/` rather than a normal product checkout, do not stop at gateway restart or manual behavior inspection. Run syntax/lint checks against the changed runtime files, a relevant pytest subset, and a focused import/behavior probe from the Hermes runtime venv.
295295

296296
**Ad-hoc verification when no canonical gate is available:** If a changed file has no project-native test/lint/build command, or the session verifier asks for fresh evidence, create a focused temporary verifier under `/tmp` with an OS-safe `hermes-verify-` filename prefix (`mktemp /tmp/hermes-verify-XXXXXX.sh` for shell or `tempfile.NamedTemporaryFile(prefix="hermes-verify-", dir="/tmp", delete=False)` for Python). The verifier should run the smallest meaningful checks for the changed behavior, assert expected outputs, and remove itself afterward when possible. Report this explicitly as "ad-hoc verification", not suite green or full repository validation.
297297

0 commit comments

Comments
 (0)