is proper fraction has been reimplemented to correctly

Author: d-odumosu

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,11 +11,7 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-    if (Number.isFinite(numerator) && Number.isFinite(denominator)) {
-        if(numerator < denominator){
-            return true
-        }
-    } return false
+  return denominator !== 0 && Math.abs(numerator / denominator) < 1;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -24,10 +20,10 @@ module.exports = isProperFraction;
 
 // Here's our helper again
 function assertEquals(actualOutput, targetOutput) {
-    console.assert(
-        actualOutput === targetOutput,
-        `Expected ${actualOutput} to equal ${targetOutput}`
-    );
+  console.assert(
+    actualOutput === targetOutput,
+    `Expected ${actualOutput} to equal ${targetOutput}`
+  );
 }
 
 // What combinations of numerators and denominators should you test?
@@ -40,20 +36,9 @@ assertEquals(isProperFraction(0, 5), true);
 assertEquals(isProperFraction(5, 0), false);
 assertEquals(isProperFraction(0, 0), false);
 assertEquals(isProperFraction(-1, 2), true);
-assertEquals(isProperFraction(1, -2), false);
-assertEquals(isProperFraction(-2, -1), true);
-assertEquals(isProperFraction(-1, -2), false);
+assertEquals(isProperFraction(1, -2), true);
+assertEquals(isProperFraction(-2, -1), false);
+assertEquals(isProperFraction(-1, -2), true);
 assertEquals(isProperFraction(0.5, 1), true);
 assertEquals(isProperFraction(1.5, 1), false);
-assertEquals(isProperFraction(Infinity, 2), false);
-assertEquals(isProperFraction(2, Infinity), false);
-assertEquals(isProperFraction(NaN, 2), false);
-assertEquals(isProperFraction(2, NaN), false);
 assertEquals(isProperFraction(999999999, 1000000000), true);
-
-
-
-
-
-
-