Skip to content

Commit 5114047

Browse files
committed
modified the throw error in jest test in 1-get-card-value.
1 parent f0d67f2 commit 5114047

3 files changed

Lines changed: 22 additions & 9 deletions

File tree

‎implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ import test from "node:test";
66
// Example: Identify Right Angles
77

88
test("Classifies acute angle", () => {
9-
assert.equal(getAngleType(45), "acute angle");
9+
assert.equal(getAngleType(45), "Acute angle");
1010
});
1111

1212
test("Classifies right angle", () => {
13-
assert.equal(getAngleType(90), "right angle");
13+
assert.equal(getAngleType(90), "Right angle");
1414
});
1515

1616
test("Classifies obtuse angle", () => {
17-
assert.equal(getAngleType(120), "obtuse angle");
17+
assert.equal(getAngleType(120), "Obtuse angle");
1818
});
1919

2020
test("Classifies straight angle", () => {
21-
assert.equal(getAngleType(180), "straight angle");
21+
assert.equal(getAngleType(180), "Straight angle");
2222
});
2323

2424
test("Classifies reflex angle", () => {
25-
assert.equal(getAngleType(200), "reflex angle");
25+
assert.equal(getAngleType(200), "Reflex angle");
2626
});
2727

2828
test("Classifies boundary and invalid angles", () => {
29-
assert.equal(getAngleType(365), "invalid angle");
30-
assert.equal(getAngleType(-10), "invalid angle");
29+
assert.equal(getAngleType(365), "Invalid angle");
30+
assert.equal(getAngleType(-10), "Invalid angle");
3131
});
3232

‎implement-and-rewrite-tests/implement/3-get-card-value.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ export function getCardValue(card) {
5252
].includes(rank);
5353
const validSuit = ["♠", "♥", "♦", "♣"].includes(suit);
5454

55-
if (!validRank || !validSuit) {
56-
throw new Error (`Expected a number followed by a suit, but got "${card}"`);
55+
if (!validRank || !validSuit || card.length > 3 || card.length < 2) {
56+
throw new Error (`Expected a number followed by a suit, but got "invalid"`);
5757
}
5858

5959
if (rank === "A") {

‎implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,21 @@ test(`Should return 11 when given an ace card`, () => {
99

1010
// Suggestion: Group the remaining test data into these categories:
1111
// Number Cards (2-10)
12+
test(`Should return 7 when given an seven card`, () => {
13+
expect(getCardValue("7♥")).toEqual(7);
14+
});
1215
// Face Cards (J, Q, K)
16+
test(`Should return 10 when given J/Q/K`, () => {
17+
expect(getCardValue("J♦")).toEqual(10);
18+
expect(getCardValue("Q♣")).toEqual(10);
19+
expect(getCardValue("K♠")).toEqual(10);
20+
});
1321
// Invalid Cards
22+
test(`Expected a number followed by a suit, but got invalid`, () => {
23+
expect(() => getCardValue("invalid")).toThrow(
24+
`Expected a number followed by a suit, but got "invalid"`
25+
);
26+
});
1427

1528
// To learn how to test whether a function throws an error as expected in Jest,
1629
// please refer to the Jest documentation:

0 commit comments

Comments
 (0)