Rewrite test messages to describe behaviours instead of exact values

Author: habohlin

implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js

@@ -6,52 +6,40 @@ import { getAngleType } from "../implement/1-get-angle-type.js";
 // TODO: Write tests to cover all cases, including boundary and invalid cases.
 // Example: Identify Right Angles
 
+test("Classifies acute angles", () => {
+  const acute1 = getAngleType(1);
+  assert.equal(acute1, "Acute angle");
+  const acute89 = getAngleType(89);
+  assert.equal(acute89, "Acute angle");
+});
+
 test("Classifies right angles", () => {
   const right = getAngleType(90);
   assert.equal(right, "Right angle");
 });
 
-test("Classifies invalid angle 0 degrees", () => {
-  const invalid = getAngleType(0);
-  assert.equal(invalid, "Invalid angle");
-});
-
-test("Classifies acute angle 1 degrees", () => {
-  const acute = getAngleType(1);
-  assert.equal(acute, "Acute angle");
-});
-
-test("Classifies acute angle 89 degrees", () => {
-  const acute = getAngleType(89);
-  assert.equal(acute, "Acute angle");
+test("Classifies obtuse angles", () => {
+  const obtuse91 = getAngleType(91);
+  assert.equal(obtuse91, "Obtuse angle");
+  const obtuse179 = getAngleType(179);
+  assert.equal(obtuse179, "Obtuse angle");
 });
 
-test("Classifies obtuse angle 91 degrees", () => {
-  const obtuse = getAngleType(91);
-  assert.equal(obtuse, "Obtuse angle");
-});
-
-test("Classifies obtuse angle 179 degrees", () => {
-  const obtuse = getAngleType(179);
-  assert.equal(obtuse, "Obtuse angle");
-});
-
-test("Classifies straight angle 180 degrees", () => {
+test("Classifies straight angles", () => {
   const straight = getAngleType(180);
   assert.equal(straight, "Straight angle");
 });
 
-test("Classifies reflex angle 181 degrees", () => {
-  const reflex = getAngleType(181);
-  assert.equal(reflex, "Reflex angle");
-});
-
-test("Classifies reflex angle 359 degrees", () => {
-  const reflex = getAngleType(359);
-  assert.equal(reflex, "Reflex angle");
+test("Classifies reflex angles", () => {
+  const reflex181 = getAngleType(181);
+  assert.equal(reflex181, "Reflex angle");
+  const reflex359 = getAngleType(359);
+  assert.equal(reflex359, "Reflex angle");
 });
 
-test("Classifies invalid angle 360 degrees", () => {
-  const invalid = getAngleType(360);
-  assert.equal(invalid, "Invalid angle");
+test("Classifies invalid angles", () => {
+  const invalid360 = getAngleType(360);
+  assert.equal(invalid360, "Invalid angle");
+  const invalid0 = getAngleType(0);
+  assert.equal(invalid0, "Invalid angle");
 });

implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js

@@ -19,72 +19,65 @@ test("Arbitrary non-card string", () => {
 
 // TODO: What other invalid card cases can you think of?
 
-test("Arbitrary non-card string '19♠'", () => {
+test("Card with number rank outside range 2-10", () => {
   assert.throws(
     () => getCardValue("19♠"),
     /Expected a number followed by a suit, but got "19♠"/,
     "Expected clear error"
   );
+  assert.throws(
+    () => getCardValue("-3♦"),
+    /Expected a number followed by a suit, but got "-3♦"/,
+    "Expected clear error"
+  );
 });
 
-test("Arbitrary non-card string 'P♦'", () => {
+test("Card with letter rank other than the correct options", () => {
   assert.throws(
     () => getCardValue("P♦"),
     /Expected a number followed by a suit, but got "P♦"/,
     "Expected clear error"
   );
-});
-
-test("Arbitrary non-card string 's♦'", () => {
   assert.throws(
     () => getCardValue("s♦"),
     /Expected a number followed by a suit, but got "s♦"/,
     "Expected clear error"
   );
-});
-
-test("Arbitrary non-card string 'sOup♦'", () => {
   assert.throws(
-    () => getCardValue("soUp♦"),
-    /Expected a number followed by a suit, but got "soUp♦"/,
+    () => getCardValue("soUp♣"),
+    /Expected a number followed by a suit, but got "soUp♣"/,
     "Expected clear error"
   );
 });
 
-test("Arbitrary non-card string '-3♦'", () => {
+test("Card with valid number rank lacking suit", () => {
   assert.throws(
-    () => getCardValue("-3♦"),
-    /Expected a number followed by a suit, but got "-3♦"/,
+    () => getCardValue("5"),
+    /Expected a number followed by a suit, but got "5"/,
     "Expected clear error"
   );
 });
 
-test("Arbitrary non-card string '5'", () => {
+test("Card with valid letter rank lacking suit", () => {
   assert.throws(
-    () => getCardValue("5"),
-    /Expected a number followed by a suit, but got "5"/,
+    () => getCardValue("Q"),
+    /Expected a number followed by a suit, but got "Q"/,
     "Expected clear error"
   );
 });
 
-test("Arbitrary non-card string 'Q'", () => {
+test("Card with valid suit lacking rank", () => {
   assert.throws(
-    () => getCardValue("Q"),
-    /Expected a number followed by a suit, but got "Q"/,
+    () => getCardValue("♠"),
+    /Expected a number followed by a suit, but got "♠"/,
     "Expected clear error"
   );
 });
 
 //Valid cases
 
-test("Valid card 'A♣'", () => {
+test("Valid cards", () => {
   assert.equal(getCardValue("A♣"), 11);
-});
-
-test("Valid card '10♣'", () => {
   assert.equal(getCardValue("10♣"), 10);
-});
-
-test("Valid card 'K♠'", () => {
   assert.equal(getCardValue("K♠"), 10);
 });

implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -5,7 +5,7 @@ import { getAngleType } from "../implement/1-get-angle-type.js";
 
 // Case 1: Acute angles
 
-test(`should return "Acute angle" when (0 < angle < 90)`, () => {
+test(`Classifies acute angles`, () => {
   // Test various acute angles, including boundary cases
   expect(getAngleType(1)).toEqual("Acute angle");
   expect(getAngleType(45)).toEqual("Acute angle");
@@ -14,35 +14,35 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
 
 // Case 2: Right angle
 
-test(`should return "Right angle" when (angle = 90)`, () => {
+test(`Classifies right angles`, () => {
   expect(getAngleType(90)).toEqual("Right angle");
 });
 
 // Case 3: Obtuse angles
 
-test(`should return "Obtuse angle" when (90 < angle < 180)`, () => {
+test(`Classifies obtuse angles`, () => {
   expect(getAngleType(91)).toEqual("Obtuse angle");
   expect(getAngleType(135)).toEqual("Obtuse angle");
   expect(getAngleType(179)).toEqual("Obtuse angle");
 });
 
 // Case 4: Straight angle
 
-test(`should return "Straight angle" when (angle = 180)`, () => {
+test(`Classifies straight angles`, () => {
   expect(getAngleType(180)).toEqual("Straight angle");
 });
 
 // Case 5: Reflex angles
 
-test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
+test(`Classifies reflex angles`, () => {
   expect(getAngleType(181)).toEqual("Reflex angle");
   expect(getAngleType(270)).toEqual("Reflex angle");
   expect(getAngleType(359)).toEqual("Reflex angle");
 });
 
 // Case 6: Invalid angles
 
-test(`should return "Invalid angle" when (angle =< 0 and angle >= 360)`, () => {
+test(`Classifies invalid angles`, () => {
   expect(getAngleType(0)).toEqual("Invalid angle");
   expect(getAngleType(-1)).toEqual("Invalid angle");
   expect(getAngleType(360)).toEqual("Invalid angle");

implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -3,34 +3,30 @@ import { isProperFraction } from "../implement/2-is-proper-fraction.js";
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
 // Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
+test(`Edge case: division by zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
 
-test(`should return true when 1 and 2 is passed`, () => {
+test(`Basic proper fraction`, () => {
   expect(isProperFraction(1, 2)).toEqual(true);
 });
 
-test(`should return false when 4 and 2 is passed`, () => {
+test(`Basic improper fraction`, () => {
   expect(isProperFraction(4, 2)).toEqual(false);
 });
 
-test(`should return false when edge case 2 and 2 is passed`, () => {
+test(`Edge case improper fraction`, () => {
   expect(isProperFraction(2, 2)).toEqual(false);
 });
 
-test(`should return true when -5 and 8 is passed`, () => {
+test(`Negative proper fraction`, () => {
   expect(isProperFraction(-5, 8)).toEqual(true);
 });
 
-test(`should return false when -8 and 5 is passed`, () => {
+test(`Negative improper fraction`, () => {
   expect(isProperFraction(-8, 5)).toEqual(false);
 });
 
-test(`should return true when 0 and 5 is passed`, () => {
+test(`Edge case proper fraction`, () => {
   expect(isProperFraction(0, 5)).toEqual(true);
-});
-
-test(`should return true when 3 and -7 is passed`, () => {
-  expect(isProperFraction(3, -7)).toEqual(true);
-});
+});

implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -10,70 +10,64 @@ test(`Should return 11 when given an ace card`, () => {
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
 
-test(`Should return 10 when given '10♣' `, () => {
+test(`Cards with valid number rank`, () => {
   expect(getCardValue("10♣")).toEqual(10);
 });
 
 //   Face Cards (J, Q, K)
 
-test(`Should return 10 when given 'K♠' `, () => {
+test(`Cards with valid letter rank`, () => {
   expect(getCardValue("K♠")).toEqual(10);
-});
-
-test(`Should return 11 when given 'A♣'`, () => {
   expect(getCardValue("A♣")).toEqual(11);
 });
 
 //   Invalid Cards
 
-test(`Should throw error when given 'invalid'`, () => {
+test(`Card with invalid string`, () => {
   expect(() => {
     getCardValue("invalid");
   }).toThrow(/Expected a number followed by a suit, but got "invalid"/);
 });
 
-test(`Should throw error when given '19♠'`, () => {
+test(`Card with number rank outside range 2-10`, () => {
   expect(() => {
     getCardValue("19♠");
   }).toThrow(/Expected a number followed by a suit, but got "19♠"/);
+  expect(() => {
+    getCardValue("-3♦");
+  }).toThrow(/Expected a number followed by a suit, but got "-3♦"/);
 });
 
-test(`Should throw error when given 'P♦'`, () => {
+test(`Card with letter rank other than the correct options`, () => {
   expect(() => {
     getCardValue("P♦");
   }).toThrow(/Expected a number followed by a suit, but got "P♦"/);
-});
-
-test(`Should throw error when given 's♦'`, () => {
   expect(() => {
     getCardValue("s♦");
   }).toThrow(/Expected a number followed by a suit, but got "s♦"/);
-});
-
-test(`Should throw error when given 'sOup♦'`, () => {
   expect(() => {
     getCardValue("sOup♦");
   }).toThrow(/Expected a number followed by a suit, but got "sOup♦"/);
 });
 
-test(`Should throw error when given '-3♦'`, () => {
-  expect(() => {
-    getCardValue("-3♦");
-  }).toThrow(/Expected a number followed by a suit, but got "-3♦"/);
-});
-
-test(`Should throw error when given '5'`, () => {
+test(`Card with valid number rank lacking suit`, () => {
   expect(() => {
     getCardValue("5");
   }).toThrow(/Expected a number followed by a suit, but got "5"/);
 });
 
-test(`Should throw error when given 'Q'`, () => {
+test(`Card with valid letter rank lacking suit`, () => {
   expect(() => {
     getCardValue("Q");
   }).toThrow(/Expected a number followed by a suit, but got "Q"/);
 });
 
+test(`Card with valid suit lacking rank`, () => {
+  expect(() => {
+    getCardValue("♠");
+  }).toThrow(/Expected a number followed by a suit, but got "♠"/);
+});
+
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror