From ce76c0b5fb978e55f4becec00641d7e9d9d98bb1 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 8 Oct 2026 21:50:50 +0100 Subject: [PATCH 01/12] add empty lines for better readability in angle type tests --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index cf50f6cad..685253f48 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -10,3 +10,5 @@ test("Classifies right angles", () => { const right = getAngleType(90); assert.equal(right, "Right angle"); }); + + From 06d0d30e85f35788645b8b62ab964773c4ddb570 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:13:46 +0100 Subject: [PATCH 02/12] exercise-1 dead code removed --- dead-code/exercise-1.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 4d09f15fa..7ae8b04cb 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -1,17 +1,12 @@ -// Find the instances of unreachable and redundant code - remove them! -// The sayHello function should continue to work for any reasonable input it's given. - -let testName = "Jerry"; const greeting = "hello"; function sayHello(greeting, name) { - const greetingStr = greeting + ", " + name + "!"; + return `${greeting}, ${name}!`; - console.log(greetingStr); -} +}; -testName = "Aman"; +let testName = "Aman" const greetingMessage = sayHello(greeting, testName); -console.log(greetingMessage); // 'hello, Aman!' +console.log(greetingMessage); From bc959ec06939e60aabc166a7585370929aca54da Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:18:32 +0100 Subject: [PATCH 03/12] removed redundant code from line 8 --- dead-code/exercise-1.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 7ae8b04cb..05fcc2203 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -1,12 +1,17 @@ +// Find the instances of unreachable and redundant code - remove them! +// The sayHello function should continue to work for any reasonable input it's given. + +let testName = "Jerry"; const greeting = "hello"; function sayHello(greeting, name) { - + return `${greeting}, ${name}!`; -}; + console.log(greetingStr); +} -let testName = "Aman" +testName = "Aman"; const greetingMessage = sayHello(greeting, testName); -console.log(greetingMessage); +console.log(greetingMessage); // 'hello, Aman!' From f9179833b5785c08bb3f7d1b2779543366e9a965 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:19:27 +0100 Subject: [PATCH 04/12] removed redundant code from line 10 and deleted empty space --- dead-code/exercise-1.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 05fcc2203..22e1fceaf 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -5,10 +5,9 @@ let testName = "Jerry"; const greeting = "hello"; function sayHello(greeting, name) { - + return `${greeting}, ${name}!`; - console.log(greetingStr); -} +}; testName = "Aman"; From 55e8451c5f7f716b40f1103e4d65aa04c239ca5a Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:20:10 +0100 Subject: [PATCH 05/12] delete comment on line 16 --- dead-code/exercise-1.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 22e1fceaf..e32f909b7 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -13,4 +13,4 @@ testName = "Aman"; const greetingMessage = sayHello(greeting, testName); -console.log(greetingMessage); // 'hello, Aman!' +console.log(greetingMessage); \ No newline at end of file From a47ff503482bd5e9e3a84068615bdbd5378201fb Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:22:13 +0100 Subject: [PATCH 06/12] delete let testName = 'Jerry' --- dead-code/exercise-1.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index e32f909b7..884f0f55c 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -1,7 +1,6 @@ // Find the instances of unreachable and redundant code - remove them! // The sayHello function should continue to work for any reasonable input it's given. -let testName = "Jerry"; const greeting = "hello"; function sayHello(greeting, name) { @@ -9,7 +8,7 @@ function sayHello(greeting, name) { return `${greeting}, ${name}!`; }; -testName = "Aman"; +let testName = "Aman"; const greetingMessage = sayHello(greeting, testName); From 37342aeab9eebe5c98419cee74a64e8728cedb9c Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:23:31 +0100 Subject: [PATCH 07/12] delete comments on line 1 and 2 and adjust code to line 1 --- dead-code/exercise-1.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 884f0f55c..6675d9862 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -1,6 +1,3 @@ -// Find the instances of unreachable and redundant code - remove them! -// The sayHello function should continue to work for any reasonable input it's given. - const greeting = "hello"; function sayHello(greeting, name) { From 0fa2fb38a877cc79e28bd0ab7a30bcbfbc534250 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:24:57 +0100 Subject: [PATCH 08/12] refactor code --- dead-code/exercise-1.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dead-code/exercise-1.js b/dead-code/exercise-1.js index 6675d9862..2309c5d72 100644 --- a/dead-code/exercise-1.js +++ b/dead-code/exercise-1.js @@ -1,12 +1,11 @@ const greeting = "hello"; function sayHello(greeting, name) { - return `${greeting}, ${name}!`; -}; +} let testName = "Aman"; const greetingMessage = sayHello(greeting, testName); -console.log(greetingMessage); \ No newline at end of file +console.log(greetingMessage); From 73c38e22133a008d6c86ad2bb7acc37096063a50 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:30:11 +0100 Subject: [PATCH 09/12] delete line 5 from code --- dead-code/exercise-2.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dead-code/exercise-2.js b/dead-code/exercise-2.js index 56d7887c4..b27bf51e2 100644 --- a/dead-code/exercise-2.js +++ b/dead-code/exercise-2.js @@ -2,12 +2,12 @@ // The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; -const capitalisedPets = pets.map((pet) => pet.toUpperCase()); +// const capitalisedPets = pets.map((pet) => pet.toUpperCase()); const petsStartingWithH = pets.filter((pet) => pet[0] === "h"); -function logPets(petsArr) { - petsArr.forEach((pet) => console.log(pet)); -} +// function logPets(petsArr) { +// petsArr.forEach((pet) => console.log(pet)); +// } function countAndCapitalisePets(petsArr) { const petCount = {}; From 70403c55430c8d0b5e0a3d0ec2a835ec9e7e5908 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:31:19 +0100 Subject: [PATCH 10/12] delete line 7 to 9 from code --- dead-code/exercise-2.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dead-code/exercise-2.js b/dead-code/exercise-2.js index b27bf51e2..b1c2362d3 100644 --- a/dead-code/exercise-2.js +++ b/dead-code/exercise-2.js @@ -2,13 +2,8 @@ // The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; -// const capitalisedPets = pets.map((pet) => pet.toUpperCase()); const petsStartingWithH = pets.filter((pet) => pet[0] === "h"); -// function logPets(petsArr) { -// petsArr.forEach((pet) => console.log(pet)); -// } - function countAndCapitalisePets(petsArr) { const petCount = {}; From e7eef76ef9b82f2392f7fa18dfda4004659a2e33 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:34:15 +0100 Subject: [PATCH 11/12] delete all comments from code --- dead-code/exercise-2.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dead-code/exercise-2.js b/dead-code/exercise-2.js index b1c2362d3..742cda950 100644 --- a/dead-code/exercise-2.js +++ b/dead-code/exercise-2.js @@ -1,6 +1,3 @@ -// Remove the unused code that does not contribute to the final console log -// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable. - const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; const petsStartingWithH = pets.filter((pet) => pet[0] === "h"); @@ -20,4 +17,4 @@ function countAndCapitalisePets(petsArr) { const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH); -console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log +console.log(countedPetsStartingWithH); \ No newline at end of file From 79dfa7a90d947fbbe70d34abbe7fdcb4934af7b2 Mon Sep 17 00:00:00 2001 From: MattCarolus10 Date: Thu, 15 Oct 2026 22:58:01 +0100 Subject: [PATCH 12/12] restore get-angle-type test from upstream --- .../implement-tests-with-node-test/1-get-angle-type.test.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index 685253f48..cf50f6cad 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -10,5 +10,3 @@ test("Classifies right angles", () => { const right = getAngleType(90); assert.equal(right, "Right angle"); }); - -