From bb5cc54de0738cef11ab03bdc04959a0d365ef94 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Tue, 27 Oct 2026 23:24:13 +0000 Subject: [PATCH 01/13] test : adding getAngleType test cases --- .../1-get-angle-type.test.js | 26 ++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js index cf50f6cad..01d4e48d0 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/1-get-angle-type.test.js @@ -6,7 +6,27 @@ import { getAngleType } from "../implement/1-get-angle-type.js"; // TODO: Write tests to cover all cases, including boundary and invalid cases. // Example: Identify Right Angles -test("Classifies right angles", () => { - const right = getAngleType(90); - assert.equal(right, "Right angle"); +test("returns Acute angle for angles between 0 and 90", () => { + assert.strictEqual(getAngleType(45), "Acute angle"); +}); + +test("returns Right angle for 90", () => { + assert.strictEqual(getAngleType(90), "Right angle"); +}); + +test("returns Obtuse angle for angles between 90 and 180", () => { + assert.strictEqual(getAngleType(120), "Obtuse angle"); +}); + +test("returns Straight angle for 180", () => { + assert.strictEqual(getAngleType(180), "Straight angle"); +}); + +test("returns Reflex angle for angles between 180 and 360", () => { + assert.strictEqual(getAngleType(270), "Reflex angle"); +}); + +test("returns Invalid angle for angles outside the valid range", () => { + assert.strictEqual(getAngleType(0), "Invalid angle"); + assert.strictEqual(getAngleType(360), "Invalid angle"); }); From 1cb8be036db873de678faee96c3e20906e41cf4e Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Tue, 27 Oct 2026 23:32:33 +0000 Subject: [PATCH 02/13] implementing getAngleType function --- .../implement/1-get-angle-type.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/1-get-angle-type.js b/implement-and-rewrite-tests/implement/1-get-angle-type.js index 8a6fba050..21898423d 100644 --- a/implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -17,5 +17,17 @@ // execute the code to ensure all tests pass. export function getAngleType(angle) { - // TODO: Implement this function + if (angle > 0 && angle < 90) { + return "Acute angle"; + } else if (angle === 90) { + return "Right angle"; + } else if (angle > 90 && angle < 180) { + return "Obtuse angle"; + } else if (angle === 180) { + return "Straight angle"; + } else if (angle > 180 && angle < 360) { + return "Reflex angle"; + } else { + return "Invalid angle"; + } } From e8703895d1d4829b0a1599c56ddec79dfc8541ab Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 00:15:06 +0000 Subject: [PATCH 03/13] jest tests --- .../1-get-angle-type.test.js | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index e0ba786ab..eb08ba9d7 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -1,3 +1,5 @@ +import { test, expect } from "@jest/globals"; + import { getAngleType } from "../implement/1-get-angle-type.js"; // TODO: Write tests in Jest syntax to cover all cases/outcomes, @@ -5,14 +7,37 @@ import { getAngleType } from "../implement/1-get-angle-type.js"; // Case 1: Acute angles test(`should return "Acute angle" when (0 < angle < 90)`, () => { - // Test various acute angles, including boundary cases expect(getAngleType(1)).toEqual("Acute angle"); expect(getAngleType(45)).toEqual("Acute angle"); expect(getAngleType(89)).toEqual("Acute angle"); }); // Case 2: Right angle +test(`should return "Right angle" for 90 degrees`, () => { + expect(getAngleType(90)).toEqual("Right angle"); +}); + // Case 3: Obtuse angles +test(`should return "Obtuse angle" when (90 < angle < 180)`, () => { + expect(getAngleType(91)).toEqual("Obtuse angle"); + expect(getAngleType(120)).toEqual("Obtuse angle"); + expect(getAngleType(179)).toEqual("Obtuse angle"); +}); + // Case 4: Straight angle +test(`should return "Straight angle" for 180 degrees`, () => { + expect(getAngleType(180)).toEqual("Straight angle"); +}); // Case 5: Reflex angles +test(`should return "Reflex angle" when (180 < angle < 360)`, () => { + expect(getAngleType(181)).toEqual("Reflex angle"); + expect(getAngleType(270)).toEqual("Reflex angle"); + expect(getAngleType(359)).toEqual("Reflex angle"); +}); + // Case 6: Invalid angles +test(`should return "Invalid angle" when ( angle <= 0 or angle >= 360)`, () => { + expect(getAngleType(181)).toEqual("Reflex angle"); + expect(getAngleType(270)).toEqual("Reflex angle"); + expect(getAngleType(359)).toEqual("Reflex angle"); +}); From 2d1d1e0274d3604d04c6ffd898260bf92fce70c2 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 22:18:21 +0000 Subject: [PATCH 04/13] test: add isProperFraction tests --- .../2-is-proper-fraction.test.js | 35 +++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index a29084605..2fe7182ba 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -6,7 +6,38 @@ import { isProperFraction } from "../implement/2-is-proper-fraction.js"; // TODO: Write tests to cover all cases. // What combinations of numerators and denominators should you test? -test("Basic proper fraction", () => { - // Example: 1/2 is a proper fraction +// Case 1: Proper fraction +test("should return true when numerator is smaller than denominator", () => { assert.equal(isProperFraction(1, 2), true); + assert.equal(isProperFraction(3, 5), true); +}); + +// Case 2: Numerator equals denominator +test("should return false when numerator equals denominator", () => { + assert.equal(isProperFraction(2, 2), false); +}); + +// Case 3: Numerator is greater than denominator +test("should return false when numerator is greater than denominator", () => { + assert.equal(isProperFraction(3, 2), false); +}); + +// Case 4: Zero numerator +test("should return true when numerator is zero", () => { + assert.equal(isProperFraction(0, 2), true); +}); + +// Case 5: Negative numerator +test("should return true when numerator is negative and denominator is positive", () => { + assert.equal(isProperFraction(-1, 2), true); +}); + +// Case 6: Negative denominator +test("should return false when denominator is negative", () => { + assert.equal(isProperFraction(1, -2), false); +}); + +// Case 7: Zero denominator +test("should return false when denominator is zero", () => { + assert.equal(isProperFraction(1, 0), false); }); From 515b79a8651e833a877e6afb7c1eb02145cf2539 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 22:18:52 +0000 Subject: [PATCH 05/13] feat: implement isProperFraction function --- .../implement/2-is-proper-fraction.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index f983800f0..8ed4286fc 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -14,5 +14,9 @@ // execute the code to ensure all tests pass. export function isProperFraction(numerator, denominator) { - // TODO: Implement this function + if (numerator < denominator) { + return true; + } else { + return false; + } } From c677fa38de46522cdde3503a6aedd37ccdbf3c1d Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 22:19:59 +0000 Subject: [PATCH 06/13] test: add Jest tests for isProperFraction --- .../2-is-proper-fraction.test.js | 22 ++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 5d49e2d8b..7e6f6b1ea 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -2,7 +2,23 @@ import { isProperFraction } from "../implement/2-is-proper-fraction.js"; // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories. -// Special case: numerator is zero -test(`should return false when denominator is zero`, () => { - expect(isProperFraction(1, 0)).toEqual(false); +test("should return true for a proper fraction", () => { + expect(isProperFraction(1, 2)).toBe(true); + expect(isProperFraction(3, 5)).toBe(true); +}); + +test("should return false when numerator equals denominator", () => { + expect(isProperFraction(2, 2)).toBe(false); +}); + +test("should return false when numerator is greater than denominator", () => { + expect(isProperFraction(3, 2)).toBe(false); +}); + +test("should return true when numerator is zero", () => { + expect(isProperFraction(0, 2)).toBe(true); +}); + +test("should return false when denominator is zero", () => { + expect(isProperFraction(1, 0)).toBe(false); }); From 51135c29d59962224a6188565f0d7fdcc636312a Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 23:34:33 +0000 Subject: [PATCH 07/13] test : add getCardValue tests --- .../3-get-card-value.test.js | 33 +++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js index f5092d9b1..1412657c8 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/3-get-card-value.test.js @@ -10,7 +10,36 @@ test("Valid single-digit card", () => { }); test("Arbitrary non-card string", () => { - assert.throws(() => getCardValue("invalid"), /Expected a number followed by a suit, but got "invalid"/, "Expected clear error"); + assert.throws( + () => getCardValue("invalid"), + /Expected a number followed by a suit, but got "invalid"/, + "Expected clear error" + ); }); -// TODO: What other invalid card cases can you think of? +test("Ace should return 11", () => { + assert.equal(getCardValue("A♠"), 11); +}); + +test("Face cards should return 10", () => { + assert.equal(getCardValue("J♠"), 10); + assert.equal(getCardValue("Q♠"), 10); + assert.equal(getCardValue("K♠"), 10); +}); + +test("Number cards should return their numeric value", () => { + assert.equal(getCardValue("2♠"), 2); + assert.equal(getCardValue("10♠"), 10); +}); + +test("Should throw an error for a missing suit", () => { + assert.throws(() => getCardValue("A"), Error); +}); + +test("Should throw an error for an invalid rank", () => { + assert.throws(() => getCardValue("X♠"), Error); +}); + +test("Should throw an error for an empty string", () => { + assert.throws(() => getCardValue(""), Error); +}); From d486f1c0f5e62df8b53274d582d9428404fb7923 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 23:35:17 +0000 Subject: [PATCH 08/13] feat: implement getCardValue function --- .../implement/3-get-card-value.js | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/3-get-card-value.js b/implement-and-rewrite-tests/implement/3-get-card-value.js index 9614ab1ee..afddaf8ff 100644 --- a/implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/implement-and-rewrite-tests/implement/3-get-card-value.js @@ -24,5 +24,19 @@ // execute the code to ensure all tests pass. export function getCardValue(card) { - // TODO: Implement this function + if (typeof card !== "string" || !/^(A|[2-9]|10|J|Q|K)[♠♥♦♣]$/.test(card)) { + throw new Error(`Expected a number followed by a suit, but got "${card}"`); + } + + if (card.startsWith("A")) { + return 11; + } + if (card.startsWith("J") || card.startsWith("Q") || card.startsWith("K")) { + return 10; + } + + const value = parseInt(card); + if (!isNaN(value)) { + return value; + } } From fb8b1f4e26ae35a777f1b4a3c3e93b70823a7708 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 23:35:41 +0000 Subject: [PATCH 09/13] test: add jest tests for getCardValue --- .../3-get-card-value.test.js | 42 +++++++++++++++++-- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index a6de5a82a..7eebd3704 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -3,8 +3,45 @@ import { getCardValue } from "../implement/3-get-card-value.js"; // TODO: Write tests in Jest syntax to cover all possible outcomes. // Case 1: Ace (A) -test(`Should return 11 when given an ace card`, () => { - expect(getCardValue("A♠")).toEqual(11); + +describe("Ace cards", () => { + test("Should return 11 when given and ace card", () => { + expect(getCardValue("A♠")).toEqual(11); + }); +}); + +describe("Number cards (2-10)", () => { + test("Should return the number for a number card", () => { + expect(getCardValue("2♠")).toEqual(2); + expect(getCardValue("5♠")).toEqual(5); + expect(getCardValue("10♠")).toEqual(10); + }); +}); + +describe("Face cards (J, Q, K)", () => { + test("Should return 10 for face cards", () => { + expect(getCardValue("J♠")).toEqual(10); + expect(getCardValue("Q♠")).toEqual(10); + expect(getCardValue("K♠")).toEqual(10); + }); +}); + +describe("Invalid cards", () => { + test("Should throw an error for an invalid card", () => { + expect(() => getCardValue("invalid")).toThrow(); + }); + + test("Should throw an error when the suit is missing", () => { + expect(() => getCardValue("A")).toThrow(); + }); + + test("Should throw an error for an invalid rank", () => { + expect(() => getCardValue("X♠")).toThrow(); + }); + + test("Should throw an error for an empty string", () => { + expect(() => getCardValue("")).toThrow(); + }); }); // Suggestion: Group the remaining test data into these categories: @@ -15,4 +52,3 @@ test(`Should return 11 when given an ace card`, () => { // To learn how to test whether a function throws an error as expected in Jest, // please refer to the Jest documentation: // https://jestjs.io/docs/expect#tothrowerror - From 22ee2ed2ce23d0c64ebd3a28b819aa422c918978 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Wed, 28 Oct 2026 23:35:54 +0000 Subject: [PATCH 10/13] removed line --- .../rewrite-tests-with-jest/1-get-angle-type.test.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index eb08ba9d7..044a9a23a 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -1,5 +1,3 @@ -import { test, expect } from "@jest/globals"; - import { getAngleType } from "../implement/1-get-angle-type.js"; // TODO: Write tests in Jest syntax to cover all cases/outcomes, From 6669713e90197903df4bf97fd34ec1e715181f9c Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Sun, 1 Nov 2026 01:24:08 +0000 Subject: [PATCH 11/13] fixed invalid angles tests for jest --- .../rewrite-tests-with-jest/1-get-angle-type.test.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index 044a9a23a..7ff860a62 100644 --- a/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -35,7 +35,8 @@ test(`should return "Reflex angle" when (180 < angle < 360)`, () => { // Case 6: Invalid angles test(`should return "Invalid angle" when ( angle <= 0 or angle >= 360)`, () => { - expect(getAngleType(181)).toEqual("Reflex angle"); - expect(getAngleType(270)).toEqual("Reflex angle"); - expect(getAngleType(359)).toEqual("Reflex angle"); + expect(getAngleType(-1)).toEqual("Invalid angle"); + expect(getAngleType(0)).toEqual("Invalid angle"); + expect(getAngleType(360)).toEqual("Invalid angle"); + expect(getAngleType(361)).toEqual("Invalid angle"); }); From 06f5b09666495006fc6715a22dd19435b1df5228 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Sun, 1 Nov 2026 01:55:01 +0000 Subject: [PATCH 12/13] Fixed my isProperFraction tests --- .../2-is-proper-fraction.test.js | 20 ++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js index 2fe7182ba..3775368e1 100644 --- a/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js +++ b/implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js @@ -23,17 +23,17 @@ test("should return false when numerator is greater than denominator", () => { }); // Case 4: Zero numerator -test("should return true when numerator is zero", () => { - assert.equal(isProperFraction(0, 2), true); +test("should return false when numerator is zero", () => { + assert.equal(isProperFraction(0, 2), false); }); // Case 5: Negative numerator -test("should return true when numerator is negative and denominator is positive", () => { - assert.equal(isProperFraction(-1, 2), true); +test("should return false when numerator is negative and denominator is positive", () => { + assert.equal(isProperFraction(-1, 2), false); }); // Case 6: Negative denominator -test("should return false when denominator is negative", () => { +test("should return false when denominator is negative and numerator is positive", () => { assert.equal(isProperFraction(1, -2), false); }); @@ -41,3 +41,13 @@ test("should return false when denominator is negative", () => { test("should return false when denominator is zero", () => { assert.equal(isProperFraction(1, 0), false); }); + +// Case 8: Both numerator and denominator are negative +test("should return false when both are negative and numerator has a smaller magnitude", () => { + assert.equal(isProperFraction(-1, -2), false); +}); + +// Case 9: Both negative but numerator has a larger magnitude +test("should return false when both are negative and numerator has a larger magnitude", () => { + assert.equal(isProperFraction(-2, -1), false); +}); From cc880dbebe4352653c9edb6242b0120bf464b9c6 Mon Sep 17 00:00:00 2001 From: Sakiya Mayow Date: Sun, 1 Nov 2026 01:55:18 +0000 Subject: [PATCH 13/13] Fixed my function --- implement-and-rewrite-tests/implement/2-is-proper-fraction.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js index 8ed4286fc..ec8d57651 100644 --- a/implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -14,7 +14,7 @@ // execute the code to ensure all tests pass. export function isProperFraction(numerator, denominator) { - if (numerator < denominator) { + if (numerator > 0 && denominator > 0 && numerator < denominator) { return true; } else { return false;