Repository navigation
Commit fc19f76
committed
Apply parent relegated constraints; make generateId monotonic
resolveConstraints: since 060bf2b ("Grid View #10") the parent's
relegatedConstraintsToChildren() result was fetched and then ignored
(`resolved = resolved.union(resolved)`). Union it into the child's
resolved constraints as intended. That commit also dropped the old
recursion into resolveConstraints(parent), which is left out on purpose.
Layout effect (resolvedConstraints, read by CodelesslyEditor's resize
delegate, size-fit panel, fit hit-testing and ListTile position model):
- ListTile leading/trailing children now get minWidth = minLeadingWidth.
- ListView children are capped at itemExtent on the scroll axis.
- GridView children get tight cell-size constraints.
- SinglePlaceholder children inherit the placeholder's constraints.
CodelesslySDK does not call resolveConstraints directly, but nodes it
processes via NodeProcessor pick up the same resolvedConstraints.
generateId: lastPushTime and the random suffix were locals, so the
same-millisecond increment branch never ran and IDs in one millisecond
were not ordered. Move that state (and the Random) to library level.
The alphabet is 63 chars (no '-'), so nextInt(63) / max index 62 were
already correct; they now derive from _kPushChars.length.
Tests: relegated_constraints_test.dart, generate_id_test.dart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019VxYXXbiQSk5HVF2LMgQhU1 parent 38b0f7b commit fc19f76
4 files changed
Lines changed: 114 additions & 14 deletions
File tree
- lib/src/api
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
7 | 18 | | |
8 | 19 | | |
9 | 20 | | |
| |||
15 | 26 | | |
16 | 27 | | |
17 | 28 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | 29 | | |
23 | 30 | | |
24 | 31 | | |
25 | | - | |
| 32 | + | |
26 | 33 | | |
27 | | - | |
| 34 | + | |
28 | 35 | | |
29 | 36 | | |
| 37 | + | |
| 38 | + | |
30 | 39 | | |
31 | | - | |
32 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
33 | 46 | | |
34 | | - | |
| 47 | + | |
35 | 48 | | |
36 | | - | |
37 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
38 | 53 | | |
39 | 54 | | |
40 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
176 | | - | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
177 | 178 | | |
178 | 179 | | |
179 | 180 | | |
| |||
189 | 190 | | |
190 | 191 | | |
191 | 192 | | |
192 | | - | |
| 193 | + | |
193 | 194 | | |
194 | 195 | | |
195 | 196 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
0 commit comments