Skip to content

control.wallet.syncStatus can still emit {phase: "synced", peak_height: null} — the pairing every money read now abolishes #495

Description

@MichaelTaylor3d

Re-homed from #490, which was asked to re-home it
rather than let it vanish: both of its former trackers
(https://github.com/DIG-Network/dig_ecosystem/issues/2761 and
https://github.com/DIG-Network/dig_ecosystem/issues/3166) are CLOSED.

Task

control.wallet.syncStatus can still emit {phase: "synced", peak_height: null} — a positive
claim that the replica is current beside a refusal to say what height it is current AT. That
pairing is abolished on every money read: balance (#454) and, as of #490, coins,
coinsByParent, coinById, coinSpend and arrivals all compute their synced from a
CURRENCY test and now carry network_peak_height/stale_by beside it. syncStatus is the one
surface a caller consults specifically to ask how current is this node, and it is the one that
can still answer with an unbounded all-clear.

Context

Scope

Decide and implement what syncStatus should say when the replica has no peak of its own.
phase: "synced" with peak_height: null must not remain the answer. The likely shape, by
analogy with the money reads, is that Synced requires a known replica peak, with the
peer-tier-unknown case reported distinctly — but the phase machine is another family's and this
ticket does not presume the fix.

Acceptance

control.wallet.syncStatus cannot emit a synced phase without a height that bounds it, and a
test asserts that pairing is unreachable rather than merely absent from a fixture.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions