Skip to content

Relaxed review process #37

Description

@illwieckz

This repository is not build by Unvanquished/Daemon, so it doesn't have to go through the same review process of Unvanquished/Daemon.

It happens that only me and @slipher are contributing to this project for now.

The only known consumer for this project right now is the external_deps/build.sh script from Unvanquished, which is usually only used less than once a year.

This means we can totally have quicker review processes for this project, without the risk of breaking things for many unknown people.

So I would like to not use the usual “1 day delay” with this repository. As soon as someone else approves a change, that would be good to merge.

For example, I have next to 10 PR pending:

I wouldn't want to wait 10 days, merging one per day, if I had worked all of them within less than 10 days.

Those PR are already more than 1 day old, but in between, @slipher also submits PRs. And then, I should rebase my own PRs above his changes.

Myself don't want to wait up to 1 day to rebase my own PRs after I approve a PR that is not mine, knowing that it will not be merged before 1 day and I will not be able to rebase on master before that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions