Skip to content

Investigate transition suppression for nested data-mode #258

Description

@zoharma

Based on changes in #220, data-mode could be applied to any container, not just the document root. However, the ThemeProvider transition suppression currently only watches document.documentElement.

This works for our current Storybook use case, where nested themes are static, but it may not be sufficient if we later support components that switch between light and dark mode independently (for example, code editors or previews).

Task

  • Review whether transition suppression should also support nested data-mode containers.
  • Decide whether the current behaviour is sufficient or should be extended.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions