From 0b539cd710c345283ef4b568009fb72ad7363e47 Mon Sep 17 00:00:00 2001 From: Leechael Yim Date: Sat, 12 Sep 2026 11:57:24 +0800 Subject: [PATCH] fix(lint): actually allow empty YAML values in yamllint config The comment in .yamllint says empty values are allowed because they are common in docker-compose files (named volumes, networks), but the rule was set to `enable`. yamllint disables empty-values by default, so `enable` turned the check on and every compose file in the repo reported errors. dev.sh swallows the yamllint exit code, so CI stayed green while GitHub surfaced the errors as failure annotations on unrelated PR diffs. Set the rule to `disable` to match the stated intent, and drop the trailing space on the empty CloudFormation `Default:` value, which was the only non-empty-values finding. Claude-Session: https://claude.ai/code/session_01Ap9Smra9D3ZLPUeKDkDYQJ --- .yamllint | 2 +- custom-domain/dstack-ingress/CLOUDFORMATION_EXAMPLE.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.yamllint b/.yamllint index ad3bcba6..dcd9d37a 100644 --- a/.yamllint +++ b/.yamllint @@ -26,4 +26,4 @@ rules: min-spaces-from-content: 1 # Allow empty values which are common in docker-compose - empty-values: enable + empty-values: disable diff --git a/custom-domain/dstack-ingress/CLOUDFORMATION_EXAMPLE.yaml b/custom-domain/dstack-ingress/CLOUDFORMATION_EXAMPLE.yaml index 7435da0b..bfd8e80f 100644 --- a/custom-domain/dstack-ingress/CLOUDFORMATION_EXAMPLE.yaml +++ b/custom-domain/dstack-ingress/CLOUDFORMATION_EXAMPLE.yaml @@ -3,7 +3,7 @@ AWSTemplateFormatVersion: '2010-09-09' Parameters: HostedZoneId: Type: String - Default: + Default: Description: Route53 Hosted Zone ID UserName: Type: String