Skip to content

Bug: tests/index.py is a divergent copy of api/index.py #571

Description

@gkorland

Description

tests/index.py is a 452-line copy of api/index.py (453 lines) with divergent logic. Key differences:

  1. The public_access decorator has inverted logic compared to the production version — it denies access when CODE_GRAPH_PUBLIC != "1" instead of bypassing token_required.
  2. Different imports (uses from api import * wildcard).
  3. Missing docstrings and comments that exist in production.

Tests using this file may pass but don't reflect production behavior.

Impact

  • Tests give false confidence — they exercise different auth logic than production
  • Two copies of the same code must be kept in sync manually, which is error-prone

Suggested Fix

Delete tests/index.py and import the actual production app for testing:

from api.index import app

Or use a test fixture that configures the real app for testing.

Context

Found during code review of PR #522.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions