From 69f72b6abf7b7fe37cedc2d3ff1cc8208ae96789 Mon Sep 17 00:00:00 2001 From: Gabriel Taveira Date: Wed, 4 Nov 2026 09:07:48 -0300 Subject: [PATCH] test: cover prototype poisoning through Expo config merges --- tools/dependency-security-check.mjs | 37 ++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/tools/dependency-security-check.mjs b/tools/dependency-security-check.mjs index 47f16ad..d973991 100644 --- a/tools/dependency-security-check.mjs +++ b/tools/dependency-security-check.mjs @@ -1,8 +1,15 @@ import assert from "node:assert/strict"; import { spawnSync } from "node:child_process"; -import { readFileSync, readdirSync } from "node:fs"; +import { + mkdtempSync, + readFileSync, + readdirSync, + rmSync, + writeFileSync, +} from "node:fs"; import { createRequire } from "node:module"; import { createServer } from "node:net"; +import { tmpdir } from "node:os"; import { dirname, join } from "node:path"; const rootRequire = createRequire(import.meta.url); @@ -315,6 +322,34 @@ for (const entry of ["index.js", "dist/cjs.js", "dist/umd.js"]) { { a: [1, 2], nested: { x: 1, y: 2 } }, ); } +// Exercise Expo's config merge, where this development dependency is used. +const { modifyConfigAsync } = requireFrom(expoPackage)("@expo/config"); +const configProject = mkdtempSync(join(tmpdir(), "code-push-config-security-")); +try { + writeFileSync( + join(configProject, "package.json"), + '{"name":"security-probe"}', + ); + writeFileSync( + join(configProject, "app.json"), + '{"expo":{"name":"probe","slug":"probe","extra":{"safe":true,"__proto__":{"polluted":true}}}}', + ); + const result = await modifyConfigAsync( + configProject, + { extra: { added: true } }, + { skipSDKVersionRequirement: true }, + { dryRun: true }, + ); + assert.equal(result.type, "success"); + assert.equal(Object.getPrototypeOf(result.config.extra), Object.prototype); + assert.equal(result.config.extra.polluted, undefined); + assert.deepEqual(result.config.extra, { safe: true, added: true }); + console.log( + "Expo config merge rejected prototype poisoning and preserved safe values.", + ); +} finally { + rmSync(configProject, { recursive: true, force: true }); +} const mmPackage = packageFrom(packageInStore("glob", "14.0.3"), "minimatch"); const mm = requireFrom(mmPackage)("minimatch"); assert.equal(typeof mm, "function");