From 675721c6d3fd4bab4f5fe831c2c3a09fc0446d7d Mon Sep 17 00:00:00 2001 From: maksymis <32574056+maksymiuks@users.noreply.github.com> Date: Mon, 21 Sep 2026 19:31:55 +0200 Subject: [PATCH] Remove duplicated deps --- DESCRIPTION | 2 +- NEWS.md | 7 +++++++ R/utils-deps.R | 7 ++++++- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index ab05194..c39e0b9 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: checked Title: Systematically Run R CMD Checks -Version: 0.6.1 +Version: 0.6.2 Authors@R: c( person( diff --git a/NEWS.md b/NEWS.md index 10565a7..c7e26dd 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,12 @@ # checked 0.6.1 +* Ignore package-dep pairs duplicate in the `pkg_dependencies` helper + when constructing dependencies data.frame. This makes sure `checked` + does not fail with packages that have multiple entries for the same dep + in the DESCRIPTION,. + +# checked 0.6.1 + * Further improve the logic behind install_process making it less vulnerable to errors coming from user configuration. diff --git a/R/utils-deps.R b/R/utils-deps.R index 8f5399c..c7d084a 100644 --- a/R/utils-deps.R +++ b/R/utils-deps.R @@ -113,7 +113,12 @@ pkg_dependencies <- function( # TODO: there is a singe package MatrixModels which specifies it. # TODO: For now we decided to skip such requirements to assess # TODO: the severity of this. - out <- out[!out$op %in% c("<", "<="), ] + # Additionally, the current logic behind revdep check is to always + # use the latest available version in the repo, as this is the only + # way to reasonable assess satisfiability. Therefore constraints are + # ignored for now letting R CMD check and deps installation + # speak for itself. Subject for possible discussions in the future. + out <- out[!duplicated(out[, c("package", "name")]), ] rownames(out) <- paste0(out$package, "-", out$name) out }