Skip to content

Commit e93a33c

Browse files
committed
test(files_reader): avoid assuming filesystem discovery order
Verify discovered entities by their GTS IDs and retain assertions for their source-file metadata. This prevents the test from failing when os.walk returns JSON and YAML files in a different order across platforms or filesystems. Signed-off-by: Artifizer <artifizer@gmail.com>
1 parent 317b24f commit e93a33c

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

‎tests/test_files_reader_coverage.py‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,16 @@ def test_reader_discovers_json_yaml_and_list_entities_and_skips_invalid_files(tm
3535

3636
entities = list(GtsFileReader(str(source)))
3737

38-
assert [entity.gts_id.id for entity in entities] == [
38+
entities_by_id = {entity.gts_id.id: entity for entity in entities}
39+
assert set(entities_by_id) == {
3940
"gts.acme.catalog._.item.v1~acme.catalog._.one.v1",
4041
"gts.acme.catalog._.item.v1~",
41-
]
42-
assert entities[0].label == "entities.json#0"
43-
assert entities[0].file.sequencesCount == 2
44-
assert entities[1].file.name == "schema.yaml"
42+
}
43+
list_entity = entities_by_id["gts.acme.catalog._.item.v1~acme.catalog._.one.v1"]
44+
schema_entity = entities_by_id["gts.acme.catalog._.item.v1~"]
45+
assert list_entity.label == "entities.json#0"
46+
assert list_entity.file.sequencesCount == 2
47+
assert schema_entity.file.name == "schema.yaml"
4548

4649

4750
def test_reader_accepts_multiple_paths_and_reset_recollects_files(tmp_path):

0 commit comments

Comments
 (0)