From ef95e21cf649de1b3e63b828f40ef3bfb9057d30 Mon Sep 17 00:00:00 2001
From: uhooi <the_uhooi@yahoo.co.jp>
Date: Fri, 4 Sep 2026 14:33:42 +0900
Subject: [PATCH] chore: add Node.js 24 to github workflows

Node.js 24 is GA as a Cloud Run functions runtime and is the current
Active LTS, but CI only covered 18, 20 and 22.

- Add 24 to the unit and conformance test matrices.
- Add a nodejs24 buildpack integration job. That runtime is provided by
  the google-24-full builder, so it uses a different builder image from
  the existing jobs.

Verified locally that `npm test` passes on Node.js 24.13.0 with no
source changes.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
---
 .github/workflows/buildpack-integration-test.yml | 11 +++++++++++
 .github/workflows/conformance.yml                |  2 +-
 .github/workflows/unit.yml                       |  2 +-
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/buildpack-integration-test.yml b/.github/workflows/buildpack-integration-test.yml
index d90a046fd..6c1e718a1 100644
--- a/.github/workflows/buildpack-integration-test.yml
+++ b/.github/workflows/buildpack-integration-test.yml
@@ -47,3 +47,14 @@ jobs:
       builder-runtime: 'nodejs22'
       builder-runtime-version: '22'
       builder-url: 'us-docker.pkg.dev/serverless-runtimes/google-22-full/builder/nodejs:latest'
+  nodejs24:
+    uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/buildpack-integration-test.yml@main
+    with:
+      http-builder-source: 'test/conformance'
+      http-builder-target: 'writeHttpDeclarative'
+      cloudevent-builder-source: 'test/conformance'
+      cloudevent-builder-target: 'writeCloudEventDeclarative'
+      prerun: 'test/conformance/prerun.sh'
+      builder-runtime: 'nodejs24'
+      builder-runtime-version: '24'
+      builder-url: 'us-docker.pkg.dev/serverless-runtimes/google-24-full/builder/nodejs:latest'
diff --git a/.github/workflows/conformance.yml b/.github/workflows/conformance.yml
index 28ce0ce08..e1ddf8b8a 100644
--- a/.github/workflows/conformance.yml
+++ b/.github/workflows/conformance.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18, 20, 22]
+        node-version: [18, 20, 22, 24]
     steps:
       - name: Harden Runner
         uses: step-security/harden-runner@a90bcbc6539c36a85cdfeb73f7e2f433735f215b # v2.15.0
diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml
index 2185a5068..f137acbb4 100644
--- a/.github/workflows/unit.yml
+++ b/.github/workflows/unit.yml
@@ -11,7 +11,7 @@ jobs:
   test:
     strategy:
       matrix:
-        node-version: [18, 20, 22]
+        node-version: [18, 20, 22, 24]
         platform: [ubuntu-latest, macos-latest, windows-latest]
     runs-on: ${{ matrix.platform }}
     steps: