From 7516f73b6b68be68bc93392f2bc28bc9842cd199 Mon Sep 17 00:00:00 2001
From: nikhil2004 <myemailnikhilsaxena@gmail.com>
Date: Fri, 18 Sep 2026 23:25:57 +0530
Subject: [PATCH] fix(paths): resolve Windows mkstemp concurrency deadlock
 (#3646)

- Wrap tempfile.mkstemp in a bounded retry loop (5 attempts, 100ms backoff) to gracefully handle transient PermissionErrors caused by Windows antivirus scanners.
- Avoids infinite hang that occurred when mkstemp hit an EACCES collision on Windows.
- Add regression tests to test_paths.py
---
 graphify/paths.py   | 17 ++++++++++++++++-
 tests/test_paths.py | 37 +++++++++++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+), 1 deletion(-)

diff --git a/graphify/paths.py b/graphify/paths.py
index a700ad1712..8fe823e5e4 100644
--- a/graphify/paths.py
+++ b/graphify/paths.py
@@ -21,6 +21,7 @@
 import re
 import stat
 import tempfile
+import time
 from pathlib import Path, PurePosixPath, PureWindowsPath
 
 GRAPHIFY_OUT = os.environ.get("GRAPHIFY_OUT", "graphify-out")
@@ -45,7 +46,21 @@ def _atomic_replace(path: "str | Path", write_fn) -> None:
     # atomic rename) and the replace writes through the link, not over it.
     real = Path(os.path.realpath(str(path)))
     real.parent.mkdir(parents=True, exist_ok=True)
-    fd, tmp = tempfile.mkstemp(dir=str(real.parent), prefix=".gfy-", suffix=".tmp")
+    
+    fd = None
+    tmp = None
+    last_err = None
+    for _retry in range(5):
+        try:
+            fd, tmp = tempfile.mkstemp(dir=str(real.parent), prefix=".gfy-", suffix=".tmp")
+            break
+        except PermissionError as e:
+            last_err = e
+            time.sleep(0.1)
+    
+    if fd is None:
+        raise RuntimeError(f"Failed to create temporary file in {real.parent} after 5 retries. Is the directory locked by an antivirus or indexing service?") from last_err
+
     try:
         with os.fdopen(fd, "w", encoding="utf-8") as f:
             write_fn(f)
diff --git a/tests/test_paths.py b/tests/test_paths.py
index 12359006fb..de5b947467 100644
--- a/tests/test_paths.py
+++ b/tests/test_paths.py
@@ -2,11 +2,15 @@
 
 from __future__ import annotations
 
+import tempfile
+from unittest.mock import patch
+
 import pytest
 
 from graphify.paths import (
     _is_test_path,
     disambiguate_ambiguous_candidates,
+    write_json_atomic,
 )
 
 
@@ -144,3 +148,36 @@ def test_is_absolute_any_platform_is_host_independent():
     from graphify.paths import is_absolute_any_platform
     assert is_absolute_any_platform("/home/ci/x.md")
     assert is_absolute_any_platform("C:/Users/u/x.md")
+
+
+def test_atomic_replace_mkstemp_retry_success(tmp_path):
+    """mkstemp PermissionError is retried up to 5 times before succeeding (#3646)."""
+    target = tmp_path / "test.json"
+
+    original_mkstemp = tempfile.mkstemp
+    mock_calls = 0
+
+    def mock_mkstemp(*args, **kwargs):
+        nonlocal mock_calls
+        mock_calls += 1
+        if mock_calls < 3:
+            raise PermissionError("Simulated locked directory")
+        return original_mkstemp(*args, **kwargs)
+
+    with patch("tempfile.mkstemp", side_effect=mock_mkstemp):
+        write_json_atomic(target, {"key": "value"})
+
+    assert target.exists()
+    assert mock_calls == 3
+
+
+def test_atomic_replace_mkstemp_retry_failure(tmp_path):
+    """mkstemp that never succeeds raises RuntimeError after 5 retries (#3646)."""
+    target = tmp_path / "test2.json"
+
+    def mock_mkstemp(*args, **kwargs):
+        raise PermissionError("Simulated locked directory permanently")
+
+    with patch("tempfile.mkstemp", side_effect=mock_mkstemp):
+        with pytest.raises(RuntimeError, match="Failed to create temporary file"):
+            write_json_atomic(target, {"key": "value"})