test: replace serialized fixture with in-memory round trip

Signed-off-by: 付典 <fudianchn@gmail.com>

Author: fudianchn

src/main/java/net/sf/jsqlparser/parser/ASTNodeAccessImpl.java

@@ -17,6 +17,8 @@
 
 public class ASTNodeAccessImpl implements ASTNodeAccess {
 
+    private static final long serialVersionUID = 3920262240331742793L;
+
     private transient Node node;
 
     @Override
@@ -31,8 +33,8 @@ public void setASTNode(Node node) {
 
     /**
      * The comments preceding this node's first token, in source order, with the original token
-     * images (line comments keep their line terminator). Empty for nodes built programmatically,
-     * which carry no AST.
+     * images. Line comments do not include their line terminator; callers must add a line break
+     * when prepending them to SQL. Empty for nodes built programmatically, which carry no AST.
      */
     public List<String> getLeadingComments() {
         Node node = getASTNode();

src/test/java/net/sf/jsqlparser/parser/LeadingCommentsTest.java

@@ -11,14 +11,15 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.List;
 import net.sf.jsqlparser.JSQLParserException;
 import net.sf.jsqlparser.statement.Statements;
 import net.sf.jsqlparser.statement.select.PlainSelect;
 import net.sf.jsqlparser.statement.select.Select;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 public class LeadingCommentsTest {
 
@@ -29,12 +30,20 @@ public void blockCommentsBeforeStatementInSourceOrder() throws JSQLParserExcepti
         assertEquals(List.of("/* keep orderby */", "/*+ FULL(t) */"), select.getLeadingComments());
     }
 
+    @ParameterizedTest
+    @ValueSource(strings = {"\n", "\r\n", "\r"})
+    public void lineCommentsExcludeLineTerminators(String lineTerminator)
+            throws JSQLParserException {
+        Select select =
+                (Select) CCJSqlParserUtil.parse("-- paging hint" + lineTerminator + "SELECT 1");
+        assertEquals(List.of("-- paging hint"), select.getLeadingComments());
+    }
+
     @Test
-    public void lineCommentBeforeStatement() throws JSQLParserException {
-        Select select = (Select) CCJSqlParserUtil.parse("-- paging hint\nSELECT 1");
-        List<String> comments = select.getLeadingComments();
-        assertEquals(1, comments.size());
-        assertTrue(comments.get(0).startsWith("-- paging hint"));
+    public void mixedCommentsRetainExactImagesAndSourceOrder() throws JSQLParserException {
+        Select select = (Select) CCJSqlParserUtil
+                .parse("/* a */ -- b\r\n// c\r/* d */ SELECT 1");
+        assertEquals(List.of("/* a */", "-- b", "// c", "/* d */"), select.getLeadingComments());
     }
 
     @Test

src/test/java/net/sf/jsqlparser/statement/SerializationTest.java

@@ -15,6 +15,7 @@
 import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
 import java.math.BigDecimal;
+import java.util.List;
 import java.util.stream.Stream;
 import net.sf.jsqlparser.JSQLParserException;
 import net.sf.jsqlparser.expression.SpannerInterleaveIn;
@@ -34,6 +35,17 @@
 import org.junit.jupiter.params.provider.ValueSource;
 
 public class SerializationTest {
+    @Test
+    void serializeSelectWithLeadingComments() throws Exception {
+        PlainSelect original = (PlainSelect) CCJSqlParserUtil
+                .parse("/* keep orderby */ SELECT id FROM mytable");
+        Assertions.assertEquals(List.of("/* keep orderby */"), original.getLeadingComments());
+        PlainSelect copy = roundTrip(original);
+        Assertions.assertEquals("SELECT id FROM mytable", copy.toString());
+        Assertions.assertNull(copy.getASTNode());
+        Assertions.assertEquals(List.of(), copy.getLeadingComments());
+    }
+
     @Test
     void serializeWithItem() throws JSQLParserException, IOException, ClassNotFoundException {
         String sqlStr =