Skip to content
This repository was archived by the owner on Dec 14, 2023. It is now read-only.
This repository was archived by the owner on Dec 14, 2023. It is now read-only.

setSendRawLogMessage(...) doesn't work #67

Description

@rwtaylorjr

The new feature for sending raw log messages doesn't work.
This is because changes in the sendRawLogMessage in the parent don't propagate downstream as arguments are passed by value and the sendRawLogMessage is a boolean primitive.

For example:
AndroidLogger logger = AndroidLogger.createInstance(…);

  • Creates a new instance of AsyncLoggingWorker which subsequently creates a new instance
 of SocketAppender with a copy of the current value of false for sendRawLogMessage.


Later i invoke logger.setSendRawLogMessage(true);
Since arguments are passed by value and Java primitives are not object references then even though
 I have set the sendRawLogMessage value in AsyncLoggingWorker, the copy in SocketAppender is not
affected and remains false.

Therefore, even though I have told AndroidLogger to send raw logging message, it is still decorating it.

I commented on this issue in 64a275a but never heard back.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions