removes homemade shielding during de-serialization

removes the homemade ‘_restoringState’ bool in favor of `mv::projects().isOpeningProject()`. Bracing `fromVariantMap` with the class bool would break when `fromVariantMap` encounters errors.

Author: thoellt

src/ColoringAction.cpp

@@ -105,7 +105,7 @@ ColoringAction::ColoringAction(QObject* parent, const QString& title) :
                     _dimensionAction3.setPointsDataset(_currentColorPointsDataset);
 
                     // Auto-select the color space for datasets with exactly two or three channels
-                    if (!_restoringState) {
+                    if (!mv::projects().isOpeningProject()) {
                         const auto numDimensions = static_cast<std::int32_t>(_currentColorPointsDataset->getNumDimensions());
 
                         if (numDimensions == 2) {
@@ -183,7 +183,7 @@ ColoringAction::ColoringAction(QObject* parent, const QString& title) :
         });
 
     connect(&_colorSpaceAction, &OptionAction::currentIndexChanged, this, [this](const std::int32_t& currentIndex) {
-        if (!_restoringState)
+        if (!mv::projects().isOpeningProject())
             applyDefaultChannels();
 
         updateChannelActionsReadOnly();
@@ -561,9 +561,6 @@ void ColoringAction::disconnectFromPublicAction(bool recursive)
 
 void ColoringAction::fromVariantMap(const QVariantMap& variantMap)
 {
-    // Suppress auto color-space selection and default channels so the saved values are honored
-    _restoringState = true;
-
     GroupAction::fromVariantMap(variantMap);
 
     // Restore the color source first so the dimension pickers are targeted at the right dataset,
@@ -577,8 +574,6 @@ void ColoringAction::fromVariantMap(const QVariantMap& variantMap)
     _colorMap1DAction.fromParentVariantMap(variantMap);
     _colorMap2DAction.fromParentVariantMap(variantMap);
 
-    _restoringState = false;
-
     // Apply the fully-restored coloring state
     updateChannelActionsReadOnly();
     updateScatterPlotWidgetColors();

src/ColoringAction.h

@@ -147,7 +147,6 @@ class ColoringAction : public VerticalGroupAction
     ColorMap1DAction        _colorMap1DAction;              /** One-dimensional color map action */
     ColorMap2DAction        _colorMap2DAction;              /** Two-dimensional color map action */
     Dataset<Points>         _currentColorPointsDataset;     /** Current color dataset */
-    bool                    _restoringState = false;        /** Guards auto color-space selection and default channels during state restore */
 
     /** Default constant color */
     static const QColor DEFAULT_CONSTANT_COLOR;
@@ -158,4 +157,4 @@ class ColoringAction : public VerticalGroupAction
 
 Q_DECLARE_METATYPE(ColoringAction)
 
-inline const auto coloringActionMetaTypeId = qRegisterMetaType<ColoringAction*>("ColoringAction");
+inline const auto coloringActionMetaTypeId = qRegisterMetaType<ColoringAction*>("ColoringAction");