From 1870b96a118e0e841bab8fbe02a8f7eab8cf729c Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Wed, 7 Oct 2026 09:19:19 +0200 Subject: [PATCH] Python: keep developer field IDs at or below 254. FIT field_definition_number is a UINT8, and 255 is the invalid value. Co-authored-by: Cursor --- python/tests/test_fields.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/python/tests/test_fields.py b/python/tests/test_fields.py index 658f8b0..2986385 100644 --- a/python/tests/test_fields.py +++ b/python/tests/test_fields.py @@ -82,6 +82,13 @@ def test_developer_field_ids_are_unique() -> None: assert len(ids) == len(set(ids)) +def test_developer_field_ids_stop_at_254() -> None: + """field_definition_number is UINT8; 255 is the FIT invalid value.""" + for field in DEVELOPER_FIELDS: + assert field.field_id is not None + assert 0 <= field.field_id <= 254 + + def test_field_lookup() -> None: assert field_by_id(93).name == "StrokeRate" assert field_by_name("DriveLength").field_id == 0