Skip to content

Commit f12ba8c

Browse files
style: fix linting
1 parent c64a3a2 commit f12ba8c

4 files changed

Lines changed: 9 additions & 4 deletions

File tree

‎src/dve/pipeline/foundry_ddb_pipeline.py‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
duckdb_get_entity_count,
1111
duckdb_write_parquet,
1212
)
13+
from dve.core_engine.configuration.v1 import V1ErrorReportConfig
1314
from dve.core_engine.exceptions import CriticalProcessingError
1415
from dve.core_engine.models import SubmissionInfo
1516
from dve.core_engine.type_hints import URI
@@ -101,10 +102,12 @@ def apply_business_rules(
101102
return submission_info, SubmissionStatus(processing_failed=True)
102103

103104
def error_report(
104-
self, submission_info: SubmissionInfo, submission_status: Optional[SubmissionStatus] = None
105+
self, submission_info: SubmissionInfo,
106+
submission_status: Optional[SubmissionStatus] = None ,
107+
error_report_config: Optional[V1ErrorReportConfig] = None,
105108
):
106109
try:
107-
return super().error_report(submission_info, submission_status)
110+
return super().error_report(submission_info, submission_status,error_report_config)
108111
except Exception as exc: # pylint: disable=W0718
109112
self._logger.exception("Error reports raised exception:")
110113
sub_stats = None

‎src/dve/pipeline/pipeline.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -969,6 +969,8 @@ def error_report(
969969

970970
self._logger.info("Reading error dataframes")
971971
if error_report_config is None:
972+
if not self.rules_path:
973+
raise AttributeError("rules path not provided")
972974
_, config, _ = load_config(submission_info.dataset_id, self.rules_path)
973975
error_report_config = config.error_report
974976
errors_df, aggregates = self._get_error_dataframes(

‎tests/test_pipeline/test_duckdb_pipeline.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ def test_error_report_step(
189189
audit_tables=audit_manager,
190190
job_run_id=1,
191191
connection=conn,
192-
rules_path=None,
192+
rules_path=PLANETS_RULES_PATH,
193193
submitted_files_path=None,
194194
)
195195

‎tests/test_pipeline/test_spark_pipeline.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ def test_error_report_step(
516516
processed_files_path=processed_files_path,
517517
audit_tables=audit_manager,
518518
job_run_id=1,
519-
rules_path=None,
519+
rules_path=PLANETS_RULES_PATH,
520520
submitted_files_path=None,
521521
spark=spark,
522522
)

0 commit comments

Comments
 (0)