Vouch request: andre-motta #2597
Closed
andre-motta
started this conversation in
Vouch Request
Replies: 2 comments
|
/vouch |
0 replies
|
@andre-motta has been vouched by @mrunalp. You can now submit pull requests to OpenShell. Welcome aboard. Please read CONTRIBUTING.md before submitting. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What do you want to work on?
I want to fix #2596
Why this change?
Building openshell python wheel from an sdist currently produces a broken package. The protobuf stubs under
_proto/are currently gitignored and generated at build time by a a mise task. This step is only wired through mise's task graph and not through the standard PEP 517 build system. Any standard build frontend (pip, build, fromager) that starts from an sdist will produce a wheel whereimport openshell._protohard fails with anImportError.This matters for downstream rebuilders and any packaging pipeline that does not replicate the specific mise workflow. Any of the three fix options from the issue are aditive so they would have zero impact on the mise
python:prototask. They will get generated twice when using mise but thats harmless since protoc overwrites the same files.Checklist
All reactions