From 5d7de3648c806ab8553db725515d0692e1940e97 Mon Sep 17 00:00:00 2001
From: abrichr <richard.abrich@mldsai.com>
Date: Wed, 4 Nov 2026 06:41:06 -0500
Subject: [PATCH] fix(flow): show rule enable state and unique indexes in the
 db code digest

---
 .../runtime/effects/db_snapshot.py            | 22 +++++++++++++++++--
 .../flow/tests/test_db_snapshot_postgres.py   | 19 ++++++++++++++++
 2 files changed, 39 insertions(+), 2 deletions(-)

diff --git a/packages/flow/openadapt_flow/runtime/effects/db_snapshot.py b/packages/flow/openadapt_flow/runtime/effects/db_snapshot.py
index 0140412fdc..44e97e84da 100644
--- a/packages/flow/openadapt_flow/runtime/effects/db_snapshot.py
+++ b/packages/flow/openadapt_flow/runtime/effects/db_snapshot.py
@@ -1318,9 +1318,27 @@ def _pg_definitions(
             "JOIN pg_language l ON l.oid = p.prolang "
             f"WHERE n.nspname IN {within} ORDER BY 1, 2, 3"
         ),
+        # pg_rules has no enabled state, so ALTER TABLE ... DISABLE RULE
+        # would not show; pg_rewrite.ev_enabled has it. A view's own
+        # _RETURN rule is left out, as pg_rules does (the view is read above).
         s.rows(
-            "SELECT schemaname, tablename, rulename, definition FROM pg_rules "
-            f"WHERE schemaname IN {within} ORDER BY 1, 2, 3"
+            "SELECT n.nspname, c.relname, r.rulename, r.ev_enabled, "
+            "pg_get_ruledef(r.oid) FROM pg_rewrite r "
+            "JOIN pg_class c ON c.oid = r.ev_class "
+            "JOIN pg_namespace n ON n.oid = c.relnamespace "
+            f"WHERE r.rulename <> '_RETURN' AND n.nspname IN {within} "
+            "ORDER BY 1, 2, 3"
+        ),
+        # A unique index decides which writes the database accepts, and one
+        # made with CREATE UNIQUE INDEX is not a constraint, so dropping it
+        # would not show in a table's definition.
+        s.rows(
+            "SELECT n.nspname, c.relname, i.relname, x.indisvalid, "
+            "pg_get_indexdef(x.indexrelid) FROM pg_index x "
+            "JOIN pg_class i ON i.oid = x.indexrelid "
+            "JOIN pg_class c ON c.oid = x.indrelid "
+            "JOIN pg_namespace n ON n.oid = c.relnamespace "
+            f"WHERE x.indisunique AND n.nspname IN {within} ORDER BY 1, 2, 3"
         ),
         s.rows(
             "SELECT schemaname, tablename, policyname, permissive, roles::text, cmd, "
diff --git a/packages/flow/tests/test_db_snapshot_postgres.py b/packages/flow/tests/test_db_snapshot_postgres.py
index 1f5d698e2c..727944800b 100644
--- a/packages/flow/tests/test_db_snapshot_postgres.py
+++ b/packages/flow/tests/test_db_snapshot_postgres.py
@@ -675,6 +675,25 @@ def test_a_change_to_types_rules_or_views_shows(pg: Pg, change: str) -> None:
     assert "(database code)" in diff(a, pg.snap(before=a), key=KEY)
 
 
+@live
+def test_disabling_a_rule_shows(pg: Pg) -> None:
+    pg.sql("CREATE RULE r AS ON INSERT TO pairs DO INSTEAD NOTHING")
+    a = pg.snap()
+    pg.sql("ALTER TABLE pairs DISABLE RULE r")
+    assert "(database code)" in diff(a, pg.snap(before=a), key=KEY)
+
+
+@live
+def test_a_unique_index_made_or_dropped_shows(pg: Pg) -> None:
+    a = pg.snap()
+    # pairs holds a duplicate a = 1, so the index covers only a = 2.
+    pg.sql("CREATE UNIQUE INDEX pairs_a ON pairs (a) WHERE a = 2")
+    b = pg.snap(before=a)
+    assert "(database code)" in diff(a, b, key=KEY)
+    pg.sql("DROP INDEX pairs_a")
+    assert "(database code)" in diff(b, pg.snap(before=b), key=KEY)
+
+
 @live
 def test_a_column_default_is_read_from_the_catalog(pg: Pg) -> None:
     pg.sql(