Read The PHP Book
'] as $expected) { +foreach (['Read The PHP Book
'] as $expected) { if (!str_contains($html, $expected)) { throw new RuntimeException("Missing rendered content: {$expected}"); } @@ -81,10 +81,13 @@ if (str_contains($html, 'No books yet.')) { throw new RuntimeException('The nonempty loop rendered its forelse branch.'); } -$empty = $renderer->render(view(__DIR__ . '/app/books.view.php', books: [])); +$empty = $renderer->render(view(__DIR__ . '/app/books.view.php', books: [], title: 'Empty books')); if (!str_contains($empty, 'No books yet.')) { throw new RuntimeException('The empty loop did not render its forelse branch.'); } +if (!str_contains($empty, '📚 {{ $book->title }} {{ $book->title }}
\r\n"; + let (backend, _dir, uri, view) = project(caller, template).await; + let offered = items(&backend, &uri, caller, "render('./page.view.php', ").await; + for name in ["book:", "title:"] { + let item = offered + .iter() + .find(|item| item.label == name) + .unwrap_or_else(|| panic!("{name}: {offered:?}")); + assert_eq!(item.detail.as_deref(), Some("View parameter")); + assert_eq!( + item.insert_text.as_deref(), + Some(format!("{name} ").as_str()) + ); + } + assert!( + !offered + .iter() + .any(|item| matches!(item.label.as_str(), "params:" | "path:")) + ); + let filtered = items(&backend, &uri, caller, "path: './page.view.php', ti").await; + assert!(filtered.iter().any(|item| item.label == "title:")); + assert!(!filtered.iter().any(|item| item.label == "book:")); + let later = items(&backend, &uri, caller, "render('./page.view.php', bo").await; + assert!(later.iter().any(|item| item.label == "book:")); + assert!(!later.iter().any(|item| item.label == "title:")); + for (name, read, ty) in [ + ("book", "{{ $book", "Book"), + ("title", ":title=\"$title", "string"), + ] { + let needle = format!("{name}:"); + let start = position_of(caller, &needle); + let end = Position::new(start.line, start.character + name.len() as u32); + let read_end = position_after(template, read); + let expected = vec![Location { + uri: view.clone(), + range: Range { + start: Position::new(read_end.line, read_end.character - name.len() as u32 - 1), + end: read_end, + }, + }]; + for at in [start, end] { + assert_eq!( + definition_locations( + goto_definition_at(&backend, &uri, at.line, at.character).await + ), + expected + ); + let hover = hover_response(&backend, &uri, at.line, at.character) + .await + .unwrap(); + let text = hover_text(&hover); + assert!( + text.contains("View parameter") && text.contains(ty), + "{hover:?}" + ); + assert_eq!(hover.range, Some(Range { start, end })); + } + } +} + +#[tokio::test] +async fn tempest_view_parameters_resolve_paths_through_the_shared_expression_engine() { + let caller = r" 'Passed'], ); +/** @var array{title?: string} $maybe */ +view('./page.view.php', ...$maybe, ti); +"; + let (backend, _dir, uri, view) = project(caller, "{{ $book->title }} {{ $external }}
+Empty
+{{ $_GET['page'] }} {{ $this->title }} {{ $copy }} +"#; + let (backend, _dir, uri, _) = project(caller, template).await; + let offered = items(&backend, &uri, caller, "'./page.view.php', ").await; + for name in [ + "books:", + "external:", + "optional:", + "arrowInput:", + "captured:", + ] { + assert!( + offered.iter().any(|item| item.label == name), + "{name}: {offered:?}" + ); + } + for name in [ + "annotationOnly:", + "local:", + "copy:", + "book:", + "parameter:", + "hidden:", + "gone:", + "comment:", + "_GET:", + "this:", + ] { + assert!( + !offered.iter().any(|item| item.label == name), + "{name}: {offered:?}" + ); + } +} + +#[tokio::test] +async fn tempest_view_parameters_keep_incomplete_calls_and_unsaved_templates_editable() { + let caller = "New template\n{{ $heading }}"; + open_php(&backend, &view, changed).await; + assert!( + definitions(&backend, &uri, complete, "title:") + .await + .is_empty() + ); + let found = definitions(&backend, &uri, complete, "heading:").await; + assert_eq!(found[0].range.start, position_of(changed, "$heading")); + assert!( + hover_response( + &backend, + &uri, + position_of(complete, "title:").line, + position_of(complete, "title:").character + ) + .await + .is_none() + ); +} + +#[tokio::test] +async fn tempest_view_parameters_leave_other_calls_values_and_custom_view_constructors_alone() { + let caller = r" +📚 {{ view('./detail.view.php', count: 42) }}
"; + open_php(&backend, &page, source).await; + open_php(&backend, &target, detail).await; + let found = definitions(&backend, &page, source, "count:").await; + assert_eq!(found.len(), 1, "{found:?}"); + assert_eq!(found[0].uri, target); + assert_eq!( + found[0].range, + Range { + start: position_of(detail, "$count"), + end: position_after(detail, "$count") + } + ); + let read = position_of(detail, "$count"); + let expected = hover_response(&backend, &target, read.line, read.character) + .await + .unwrap(); + let at = position_of(source, "count:"); + let hover = hover_response(&backend, &page, at.line, at.character) + .await + .unwrap(); + assert!( + hover_text(&hover).contains(hover_text(&expected)), + "{hover:?} vs {expected:?}" + ); + assert_eq!( + hover.range, + Some(Range { + start: at, + end: Position::new(at.line, at.character + 5) + }) + ); +}