Isolate analyzer reports and documentation artifacts

Author: MariusStorhaug

.github/workflows/Build-Docs.yml

@@ -49,33 +49,6 @@ jobs:
           if-no-files-found: error
           retention-days: 1
 
-      - name: Commit all changes
-        uses: PSModule/GitHub-Script@8083ec1f733f00357ee4d0db0c6056686e483bc0 # v1.9.0
-        with:
-          Debug: ${{ fromJson(inputs.Settings).Debug }}
-          Prerelease: ${{ fromJson(inputs.Settings).Prerelease }}
-          Verbose: ${{ fromJson(inputs.Settings).Verbose }}
-          Version: ${{ fromJson(inputs.Settings).Version }}
-          WorkingDirectory: ${{ fromJson(inputs.Settings).WorkingDirectory }}
-          Script: |
-            # Rename the gitignore file to .gitignore.bak
-            if (Test-Path -Path .gitignore) {
-                Rename-Item -Path '.gitignore' -NewName '.gitignore.bak' -Force
-            }
-
-            try {
-                # Add all changes to the repository
-                git add .
-                git commit -m 'Update documentation'
-            } catch {
-                Write-Host "No changes to commit"
-            }
-
-            # Restore the gitignore file
-            if (Test-Path -Path .gitignore.bak) {
-                Rename-Item -Path '.gitignore.bak' -NewName '.gitignore' -Force
-            }
-
       - name: Lint documentation
         id: super-linter
         uses: super-linter/super-linter/slim@4ce20838b8ab83717e78138c5b3a1407148e0918 # v8.7.0

.github/workflows/Lint-SourceCode.yml

@@ -35,4 +35,5 @@ jobs:
           Path: src
           WorkingDirectory: ${{ fromJson(inputs.Settings).WorkingDirectory }}
           TestResult_Enabled: true
+          TestResult_OutputPath: ${{ fromJson(inputs.Settings).WorkingDirectory }}/.PSModule/TestResult/PSModuleLint-SourceCode-${{ runner.os }}-TestResult-Report.xml
           TestResult_TestSuiteName: PSModuleLint-SourceCode-${{ runner.os }}

.github/workflows/Test-Module.yml

@@ -79,4 +79,5 @@ jobs:
           Verbose: ${{ fromJson(inputs.Settings).Verbose }}
           WorkingDirectory: ${{ fromJson(inputs.Settings).WorkingDirectory }}
           TestResult_Enabled: true
+          TestResult_OutputPath: ${{ fromJson(inputs.Settings).WorkingDirectory }}/.PSModule/TestResult/PSModuleLint-Module-${{ runner.os }}-TestResult-Report.xml
           TestResult_TestSuiteName: PSModuleLint-Module-${{ runner.os }}

.github/workflows/Workflow-Test-Default.yml

@@ -76,6 +76,48 @@ jobs:
           persist-credentials: false
           fetch-depth: 0
 
+      - name: Verify generated artifacts remain isolated
+        shell: pwsh
+        run: |
+          $expectedAnalyzerReportPaths = @{
+              '.github/workflows/Test-Module.yml' = 'TestResult_OutputPath: ${{ fromJson(inputs.Settings).WorkingDirectory }}/.PSModule/TestResult/PSModuleLint-Module-${{ runner.os }}-TestResult-Report.xml'
+              '.github/workflows/Lint-SourceCode.yml' = 'TestResult_OutputPath: ${{ fromJson(inputs.Settings).WorkingDirectory }}/.PSModule/TestResult/PSModuleLint-SourceCode-${{ runner.os }}-TestResult-Report.xml'
+          }
+
+          foreach ($workflowPath in $expectedAnalyzerReportPaths.Keys) {
+              $content = Get-Content -Path $workflowPath -Raw
+              $expectedPath = $expectedAnalyzerReportPaths[$workflowPath]
+
+              if (-not $content.Contains($expectedPath)) {
+                  throw "Expected isolated analyzer report path was not found in $workflowPath."
+              }
+          }
+
+          $buildDocsWorkflow = Get-Content -Path '.github/workflows/Build-Docs.yml' -Raw
+          $forbiddenStagingPatterns = @(
+              'Rename-Item\s+-Path\s+[''"]\.gitignore[''"]'
+              'git add \.'
+              'PSModule/GitHub-Script'
+          )
+
+          foreach ($pattern in $forbiddenStagingPatterns) {
+              if ($buildDocsWorkflow -match $pattern) {
+                  throw "Build-Docs.yml must not use generated-artifact staging: $pattern"
+              }
+          }
+
+          $legacyArtifactPaths = @(
+              'tests/srcTestRepo/TestResult'
+              'tests/srcTestRepo/CodeCoverage'
+              'tests/srcTestRepo/.temp'
+          )
+
+          foreach ($path in $legacyArtifactPaths) {
+              if (Test-Path -Path $path) {
+                  throw "Legacy root artifact path was created: $path"
+              }
+          }
+
       - name: Download docs artifact
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
         with: