From eac4a51b0518c8850e0bf691fc389caff20e189a Mon Sep 17 00:00:00 2001 From: David Vadovszki Date: Fri, 25 Sep 2026 15:21:28 -0600 Subject: [PATCH 1/3] test: drop SCOPED_TRACE from MissingOrEmptyGenericChildIdIsRejected The test crashes with SEH 0xc0000005 in the pixi_conda_build (windows-latest) job on every PR since #30, while the cmake Windows job, which builds gtest from source through conan, passes. It is the only test in the suite that uses SCOPED_TRACE. Stream the child tag into the assertion instead. Co-Authored-By: Claude Opus 5.5 --- tests/gtest_reactive.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/gtest_reactive.cpp b/tests/gtest_reactive.cpp index b879b5df2..72df4e684 100644 --- a/tests/gtest_reactive.cpp +++ b/tests/gtest_reactive.cpp @@ -297,7 +297,6 @@ TEST(Reactive, MissingOrEmptyGenericChildIdIsRejected) // GIVEN generic child tags without a usable registered ID. for(const char* child : { "", R"()" }) { - SCOPED_TRACE(child); BT::BehaviorTreeFactory factory; const std::string xml = std::string(R"( )") + @@ -305,6 +304,6 @@ TEST(Reactive, MissingOrEmptyGenericChildIdIsRejected) // WHEN registering the malformed tree. // THEN the generic tag cannot stand in for a registered Behavior. - EXPECT_THROW(factory.registerBehaviorTreeFromText(xml), BT::RuntimeError); + EXPECT_THROW(factory.registerBehaviorTreeFromText(xml), BT::RuntimeError) << child; } } From e87cb6cc52162f8a3e382de10e90006eae67251c Mon Sep 17 00:00:00 2001 From: David Vadovszki Date: Fri, 25 Sep 2026 15:21:28 -0600 Subject: [PATCH 2/3] ci: run push workflows on main The push triggers name master, which here mirrors upstream, while PRs merge to main, the default branch. No workflow runs on merge to main, so the pixi Windows crash introduced by #30 never showed there. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/cmake_ubuntu.yml | 2 +- .github/workflows/cmake_windows.yml | 2 +- .github/workflows/pixi.yaml | 2 +- .github/workflows/pre-commit.yaml | 2 +- .github/workflows/ros2-rolling.yaml | 2 +- .github/workflows/ros2.yaml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/cmake_ubuntu.yml b/.github/workflows/cmake_ubuntu.yml index 41ed9a196..823d59f07 100644 --- a/.github/workflows/cmake_ubuntu.yml +++ b/.github/workflows/cmake_ubuntu.yml @@ -3,7 +3,7 @@ name: cmake Ubuntu on: push: branches: - - master + - main pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/cmake_windows.yml b/.github/workflows/cmake_windows.yml index b4b0a763e..66e53cfd6 100644 --- a/.github/workflows/cmake_windows.yml +++ b/.github/workflows/cmake_windows.yml @@ -3,7 +3,7 @@ name: cmake Windows on: push: branches: - - master + - main pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/pixi.yaml b/.github/workflows/pixi.yaml index a5b265a6c..c95834c9d 100644 --- a/.github/workflows/pixi.yaml +++ b/.github/workflows/pixi.yaml @@ -3,7 +3,7 @@ name: Pixi (conda) on: push: branches: - - master + - main pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/pre-commit.yaml b/.github/workflows/pre-commit.yaml index ee7fa9229..a43ac32d8 100644 --- a/.github/workflows/pre-commit.yaml +++ b/.github/workflows/pre-commit.yaml @@ -3,7 +3,7 @@ name: pre-commit on: push: branches: - - master + - main pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/ros2-rolling.yaml b/.github/workflows/ros2-rolling.yaml index 5d08cead7..04c6dd28a 100644 --- a/.github/workflows/ros2-rolling.yaml +++ b/.github/workflows/ros2-rolling.yaml @@ -3,7 +3,7 @@ name: ros2-rolling on: push: branches: - - master + - main pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/ros2.yaml b/.github/workflows/ros2.yaml index 099cc04f2..0e21b0296 100644 --- a/.github/workflows/ros2.yaml +++ b/.github/workflows/ros2.yaml @@ -3,7 +3,7 @@ name: ros2 on: push: branches: - - master + - main pull_request: types: [opened, synchronize, reopened] From 9b1e3b3a158559a26c16d52c9bb9d8c9a2440e8d Mon Sep 17 00:00:00 2001 From: David Vadovszki Date: Fri, 25 Sep 2026 16:31:38 -0600 Subject: [PATCH 3/3] Revert "ci: run push workflows on main" Workflow changes need a human reviewer to override CodeRabbit's pre-merge check, which would hold up the crash fix. The trigger change moves to its own PR. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/cmake_ubuntu.yml | 2 +- .github/workflows/cmake_windows.yml | 2 +- .github/workflows/pixi.yaml | 2 +- .github/workflows/pre-commit.yaml | 2 +- .github/workflows/ros2-rolling.yaml | 2 +- .github/workflows/ros2.yaml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/cmake_ubuntu.yml b/.github/workflows/cmake_ubuntu.yml index 823d59f07..41ed9a196 100644 --- a/.github/workflows/cmake_ubuntu.yml +++ b/.github/workflows/cmake_ubuntu.yml @@ -3,7 +3,7 @@ name: cmake Ubuntu on: push: branches: - - main + - master pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/cmake_windows.yml b/.github/workflows/cmake_windows.yml index 66e53cfd6..b4b0a763e 100644 --- a/.github/workflows/cmake_windows.yml +++ b/.github/workflows/cmake_windows.yml @@ -3,7 +3,7 @@ name: cmake Windows on: push: branches: - - main + - master pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/pixi.yaml b/.github/workflows/pixi.yaml index c95834c9d..a5b265a6c 100644 --- a/.github/workflows/pixi.yaml +++ b/.github/workflows/pixi.yaml @@ -3,7 +3,7 @@ name: Pixi (conda) on: push: branches: - - main + - master pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/pre-commit.yaml b/.github/workflows/pre-commit.yaml index a43ac32d8..ee7fa9229 100644 --- a/.github/workflows/pre-commit.yaml +++ b/.github/workflows/pre-commit.yaml @@ -3,7 +3,7 @@ name: pre-commit on: push: branches: - - main + - master pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/ros2-rolling.yaml b/.github/workflows/ros2-rolling.yaml index 04c6dd28a..5d08cead7 100644 --- a/.github/workflows/ros2-rolling.yaml +++ b/.github/workflows/ros2-rolling.yaml @@ -3,7 +3,7 @@ name: ros2-rolling on: push: branches: - - main + - master pull_request: types: [opened, synchronize, reopened] diff --git a/.github/workflows/ros2.yaml b/.github/workflows/ros2.yaml index 0e21b0296..099cc04f2 100644 --- a/.github/workflows/ros2.yaml +++ b/.github/workflows/ros2.yaml @@ -3,7 +3,7 @@ name: ros2 on: push: branches: - - main + - master pull_request: types: [opened, synchronize, reopened]