From d2c4890cb4152bdfdfd19d73950da6dab8669dd7 Mon Sep 17 00:00:00 2001 From: alpha Date: Tue, 15 Sep 2026 10:19:14 -0400 Subject: [PATCH] fix(mock): say "mock interview", not "practice interview" The setting was the one screen naming the feature something the user would not see again: the app's noun is "mock interview" on the launch card, the setup dialog, the report, the transcript header and the save prompts. "Practise" stays where it is the verb, as the home screen already uses it. Closes #129 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01Kt5ucR5XPzzzxqPYzSpXaL --- .../components/custom/settings/mock-hints-field.tsx | 13 +++++++------ src/renderer/hooks/use-mock-live-suggestions.ts | 8 ++++---- src/renderer/pages/configuration/index.tsx | 2 +- src/renderer/pages/onboarding/index.tsx | 6 +++--- 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/renderer/components/custom/settings/mock-hints-field.tsx b/src/renderer/components/custom/settings/mock-hints-field.tsx index 764c8911..b13c0760 100644 --- a/src/renderer/components/custom/settings/mock-hints-field.tsx +++ b/src/renderer/components/custom/settings/mock-hints-field.tsx @@ -2,7 +2,7 @@ import { Checkbox } from '@/components/ui/checkbox'; import { useMockLiveSuggestions } from '@/hooks/use-mock-live-suggestions'; /** - * Whether a practice interview also shows what the live assistant would have answered, on the + * Whether a mock interview also shows what the live assistant would have answered, on the * configuration page and in the first-run wizard. * * The same row shape `TranscriptPanelField` uses, and here for the same reason the setting has a @@ -15,17 +15,18 @@ export function MockHintsField() { return ( ); diff --git a/src/renderer/hooks/use-mock-live-suggestions.ts b/src/renderer/hooks/use-mock-live-suggestions.ts index 836c308a..9875be97 100644 --- a/src/renderer/hooks/use-mock-live-suggestions.ts +++ b/src/renderer/hooks/use-mock-live-suggestions.ts @@ -4,8 +4,8 @@ import { toast } from 'sonner'; import { useConfigStore } from './use-config-store'; /** - * Whether a mock session also generates what the live assistant would have suggested, plus a - * toggle that persists the change. + * Whether a mock interview also generates what the live assistant would have suggested, plus + * setters that persist a change. * * Absent means **on**, the same direction `hintOnlyMode` is read in, and the main-process store * backfills the same default - so the two sides agree about a config written before the setting @@ -13,8 +13,8 @@ import { useConfigStore } from './use-config-store'; * unaided is the point, and it is asked in the first-run wizard rather than only discoverable * on the session bar. * - * Shared by the session bar, the configuration page and the onboarding wizard. `toggle` reads - * the store imperatively so it stays referentially stable. + * Shared by the mock interview bar, the configuration page and the onboarding wizard. `toggle` + * reads the store imperatively so it stays referentially stable. */ export function useMockLiveSuggestions() { const { config } = useConfigStore(); diff --git a/src/renderer/pages/configuration/index.tsx b/src/renderer/pages/configuration/index.tsx index 10e173c9..7017864f 100644 --- a/src/renderer/pages/configuration/index.tsx +++ b/src/renderer/pages/configuration/index.tsx @@ -13,7 +13,7 @@ import { ZoomField } from '@/components/custom/settings/zoom-field'; import { Button } from '@/components/ui/button'; /** - * How the interview runs: the microphone, the language, how suggestions read, whether practice + * How the interview runs: the microphone, the language, how suggestions read, whether mock * interviews show them at all, and whether the transcript is docked. * * Every control here writes straight through to the config store as it is changed - there is no diff --git a/src/renderer/pages/onboarding/index.tsx b/src/renderer/pages/onboarding/index.tsx index 360059ac..e1df424c 100644 --- a/src/renderer/pages/onboarding/index.tsx +++ b/src/renderer/pages/onboarding/index.tsx @@ -83,10 +83,10 @@ const STEPS: Step[] = [ }, { id: 'mock-hints', - label: 'Practice', - title: 'Hints while you practise?', + label: 'Mock interview', + title: 'Hints in a mock interview?', description: - 'Practice interviews are the ones you run against yourself. This decides whether they hand you the answer as well.', + 'A mock interview is where you practise against the AI interviewer. This decides whether it hands you the answer as well.', }, { id: 'zoom',