From f2cab84b0c7bbd3539fc51152d2ffb2e833518f0 Mon Sep 17 00:00:00 2001
From: Chunel <Chunel@foxmail.com>
Date: Tue, 11 Aug 2026 22:38:01 +0800
Subject: [PATCH] [perf] optimise thread pool commit func

---
 src/UtilsCtrl/ThreadPool/UThreadPool.h   |  8 ++++----
 src/UtilsCtrl/ThreadPool/UThreadPool.inl | 16 ++++++++--------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/UtilsCtrl/ThreadPool/UThreadPool.h b/src/UtilsCtrl/ThreadPool/UThreadPool.h
index 90533bc9..fac28db3 100644
--- a/src/UtilsCtrl/ThreadPool/UThreadPool.h
+++ b/src/UtilsCtrl/ThreadPool/UThreadPool.h
@@ -70,9 +70,9 @@ class UThreadPool : public UThreadObject {
      * @return
      */
     template<typename FunctionType>
-    auto commit(const FunctionType& func,
+    auto commit(FunctionType&& func,
                 CIndex index = CGRAPH_DEFAULT_TASK_STRATEGY)
-    -> std::future<decltype(std::declval<FunctionType>()())>;
+    -> std::future<decltype(std::declval<typename std::decay<FunctionType>::type>()())>;
 
     /**
      * 向特定的线程id中，提交任务信息
@@ -84,8 +84,8 @@ class UThreadPool : public UThreadObject {
      * @return
      */
     template<typename FunctionType>
-    auto commitWithTid(const FunctionType& func, CIndex tid, CBool enable, CBool lockable)
-    -> std::future<decltype(std::declval<FunctionType>()())>;
+    auto commitWithTid(FunctionType&& func, CIndex tid, CBool enable, CBool lockable)
+    -> std::future<decltype(std::declval<typename std::decay<FunctionType>::type>()())>;
 
     /**
      * 根据优先级，执行任务
diff --git a/src/UtilsCtrl/ThreadPool/UThreadPool.inl b/src/UtilsCtrl/ThreadPool/UThreadPool.inl
index 3c43e3cb..ef3cb1e5 100644
--- a/src/UtilsCtrl/ThreadPool/UThreadPool.inl
+++ b/src/UtilsCtrl/ThreadPool/UThreadPool.inl
@@ -13,11 +13,11 @@
 
 CGRAPH_NAMESPACE_BEGIN
 template<typename FunctionType>
-auto UThreadPool::commit(const FunctionType& func, CIndex index)
--> std::future<decltype(std::declval<FunctionType>()())> {
-    using ResultType = decltype(std::declval<FunctionType>()());
+auto UThreadPool::commit(FunctionType&& func, CIndex index)
+-> std::future<decltype(std::declval<typename std::decay<FunctionType>::type>()())> {
+    using ResultType = decltype(std::declval<typename std::decay<FunctionType>::type>()());
 
-    std::packaged_task<ResultType()> task(func);
+    std::packaged_task<ResultType()> task(std::forward<FunctionType>(func));
     std::future<ResultType> result(task.get_future());
 
     execute(std::move(task), index);
@@ -26,10 +26,10 @@ auto UThreadPool::commit(const FunctionType& func, CIndex index)
 
 
 template<typename FunctionType>
-auto UThreadPool::commitWithTid(const FunctionType& func, CIndex tid, CBool enable, CBool lockable)
--> std::future<decltype(std::declval<FunctionType>()())> {
-    using ResultType = decltype(std::declval<FunctionType>()());
-    std::packaged_task<ResultType()> task(std::move(func));
+auto UThreadPool::commitWithTid(FunctionType&& func, CIndex tid, CBool enable, CBool lockable)
+-> std::future<decltype(std::declval<typename std::decay<FunctionType>::type>()())> {
+    using ResultType = decltype(std::declval<typename std::decay<FunctionType>::type>()());
+    std::packaged_task<ResultType()> task(std::forward<FunctionType>(func));
     std::future<ResultType> result(task.get_future());
 
     executeWithTid(std::move(task), tid, enable, lockable);