[Bug] Adventure lines, should apply Component from kyori library.

[imDMK]

API version

2.5.2

Server software and version

1.21.5

Steps to reproduce

1. Use #setAdventureLines/#setAdventureLine

Expected behaviour

1. Use #setAdventureLines/#setAdventureLine
2. Components are applied to sign

What is actually happening?

These methods, should apply for Component kyori. This is the support for adventure API.

Code snippets

No response

Any additional comments?

No response

[Rapha149]

Do you mean that the method uses the parameter type Object instead of Component?
If yes: right now I don't know why I did that but I must have had a reason for it. I will look further into it later.

[imDMK]

No,
in the API you use Object as a parameter, which is fine — but in the version-specific implementation, you're using Component from net.minecraft, not from kyori. That's why Kyori components don't work.

[Rapha149]

I don't exactly understand what you mean, I convert the kyori components to net.minecraft components using a class from Paper here:

SignGUI/Mojang1_21_R4/src/main/java/de/rapha149/signgui/version/MojangWrapper1_21_R4.java

Line 51 in 18926ad

if (line instanceof net.kyori.adventure.text.Component component) {

but you can, and in fact must, supply net.kyori.adventure.text.Component, otherwise the API will throw an exception.