From 86dd0e8d9de258d4f7076e9c69b7cef682e767cb Mon Sep 17 00:00:00 2001 From: Mike Sullivan Date: Thu, 30 Jul 2026 14:54:37 +0100 Subject: [PATCH 1/3] when project is edited and changed the chi value is reset --- rascal2/ui/presenter.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rascal2/ui/presenter.py b/rascal2/ui/presenter.py index d82d6226..ae28e261 100644 --- a/rascal2/ui/presenter.py +++ b/rascal2/ui/presenter.py @@ -299,6 +299,8 @@ def edit_project(self, updated_project: dict, preview: bool = True) -> None: """ project_dict = self.model.project.model_dump() + if project_dict != updated_project: + self.view.controls_widget.update_chi_squared('') project_dict.update(updated_project) self.model.project.model_validate(project_dict) self.view.undo_stack.push(commands.EditProject(updated_project, self, preview=preview)) From 51e505d936e1146119cf7cfb38df56320d616a2d Mon Sep 17 00:00:00 2001 From: Mike Sullivan Date: Wed, 5 Aug 2026 17:13:11 +0100 Subject: [PATCH 2/3] Updating the new chi squared value is done in AbstractModelEdit --- rascal2/core/commands.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rascal2/core/commands.py b/rascal2/core/commands.py index b1e6d13c..1bf70968 100644 --- a/rascal2/core/commands.py +++ b/rascal2/core/commands.py @@ -60,6 +60,7 @@ def undo(self): self.update_attribute(self.old_values) if self.preview: self.presenter.model.update_results(self.old_result) + self.presenter.view.controls_widget.update_chi_squared(self.old_result.calculationResults.sumChi) def redo(self): self.update_attribute(self.new_values) @@ -73,6 +74,7 @@ def redo(self): LOGGER.error(message, exc_info=ex) self.presenter.view.terminal_widget.write(message) self.presenter.model.update_results(self.new_result) + self.presenter.view.controls_widget.update_chi_squared(self.new_result.calculationResults.sumChi) else: self.new_result = self.old_result From cd840174f8e920fe5ddcffced234fe24a7bb650a Mon Sep 17 00:00:00 2001 From: Mike Sullivan Date: Wed, 5 Aug 2026 17:17:56 +0100 Subject: [PATCH 3/3] ruff fix --- rascal2/ui/presenter.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/rascal2/ui/presenter.py b/rascal2/ui/presenter.py index ae28e261..d82d6226 100644 --- a/rascal2/ui/presenter.py +++ b/rascal2/ui/presenter.py @@ -299,8 +299,6 @@ def edit_project(self, updated_project: dict, preview: bool = True) -> None: """ project_dict = self.model.project.model_dump() - if project_dict != updated_project: - self.view.controls_widget.update_chi_squared('') project_dict.update(updated_project) self.model.project.model_validate(project_dict) self.view.undo_stack.push(commands.EditProject(updated_project, self, preview=preview))