From 7627e404b77ab463ae2d433190eeafa2779c1ecb Mon Sep 17 00:00:00 2001 From: mintaka Date: Thu, 27 Aug 2026 18:19:40 -0400 Subject: [PATCH] test(forge): fix matrixChecksRoller to current ChecksRoller signature (RIG-2848) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The RIG-2848 notification-matrix test double still returned the removed ingest.ChecksResult placeholder, which RIG-2732 (#677) collapsed into the real forge.ConditionalResult[forge.Checks] when it landed the conditional-read seam. The two PRs merged in an order that left main red — compass-go:vet/test fail-closed on `undefined: ingest.ChecksResult` in server/forge_notify_matrix_test.go, blocking every compass PR at the pre-push gate. Update matrixChecksRoller's field and RollUp return to forge.ConditionalResult[forge.Checks] (the forge import already present), matching the ChecksRoller interface. Mechanical adapter fix; the signature dictates the exact change. Spec-impact: none. Refs RIG-2848 Co-authored-by: Matt Wilkinson --- go/server/forge_notify_matrix_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go/server/forge_notify_matrix_test.go b/go/server/forge_notify_matrix_test.go index b4e9199aa..014e61a2f 100644 --- a/go/server/forge_notify_matrix_test.go +++ b/go/server/forge_notify_matrix_test.go @@ -336,10 +336,10 @@ func (d *matrixDispatcher) Notify(_ context.Context, _ string, n *compassv1inter // matrixChecksRoller scripts the combined roll-up for a CHECKS event. type matrixChecksRoller struct { - res ingest.ChecksResult + res forge.ConditionalResult[forge.Checks] } -func (c *matrixChecksRoller) RollUp(context.Context, string, uint64, string, string) (ingest.ChecksResult, error) { +func (c *matrixChecksRoller) RollUp(context.Context, string, uint64, string, string) (forge.ConditionalResult[forge.Checks], error) { return c.res, nil }