From 7627e404b77ab463ae2d433190eeafa2779c1ecb Mon Sep 17 00:00:00 2001 From: mintaka Date: Thu, 27 Aug 2026 18:19:40 -0400 Subject: [PATCH 1/2] test(forge): fix matrixChecksRoller to current ChecksRoller signature (RIG-2848) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The RIG-2848 notification-matrix test double still returned the removed ingest.ChecksResult placeholder, which RIG-2732 (#677) collapsed into the real forge.ConditionalResult[forge.Checks] when it landed the conditional-read seam. The two PRs merged in an order that left main red — compass-go:vet/test fail-closed on `undefined: ingest.ChecksResult` in server/forge_notify_matrix_test.go, blocking every compass PR at the pre-push gate. Update matrixChecksRoller's field and RollUp return to forge.ConditionalResult[forge.Checks] (the forge import already present), matching the ChecksRoller interface. Mechanical adapter fix; the signature dictates the exact change. Spec-impact: none. Refs RIG-2848 Co-authored-by: Matt Wilkinson --- go/server/forge_notify_matrix_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go/server/forge_notify_matrix_test.go b/go/server/forge_notify_matrix_test.go index b4e9199aa..014e61a2f 100644 --- a/go/server/forge_notify_matrix_test.go +++ b/go/server/forge_notify_matrix_test.go @@ -336,10 +336,10 @@ func (d *matrixDispatcher) Notify(_ context.Context, _ string, n *compassv1inter // matrixChecksRoller scripts the combined roll-up for a CHECKS event. type matrixChecksRoller struct { - res ingest.ChecksResult + res forge.ConditionalResult[forge.Checks] } -func (c *matrixChecksRoller) RollUp(context.Context, string, uint64, string, string) (ingest.ChecksResult, error) { +func (c *matrixChecksRoller) RollUp(context.Context, string, uint64, string, string) (forge.ConditionalResult[forge.Checks], error) { return c.res, nil } From 62099244ab17549817522c7ecfad38ee93bf2288 Mon Sep 17 00:00:00 2001 From: mintaka Date: Thu, 27 Aug 2026 18:20:01 -0400 Subject: [PATCH 2/2] docs(server): drop redundant public-URL rationale comment (RIG-2717) Remove the floating comment above errUsage that editorialized the no-default public-URL decision with deployment/business framing ("the managed-service host is a deployment concern that never lives in this repo"). It attaches to no declaration and every behavioral fact it stated is already documented at its proper home: the --public-url flag help (no default, must be set), requirePublicURL / errNoPublicURL (empty rejected at boot for a Linear-webhook deploy), and deepLinkFor (empty base yields a relative fragment). The rationale prose reads as out-of-place editorializing in the OSS product's source. Follow-up to #639 (merged at its pre-fix head). Spec-impact: none. Refs RIG-2717 Co-authored-by: Matt Wilkinson --- go/cmd/compass-server/main.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/go/cmd/compass-server/main.go b/go/cmd/compass-server/main.go index 049d3078d..086a7ac31 100644 --- a/go/cmd/compass-server/main.go +++ b/go/cmd/compass-server/main.go @@ -32,12 +32,6 @@ var version = "0.1.0" // RPC). const apiVersion = "compass.v1" -// (no default public URL: the managed-service host is a deployment concern that -// never lives in this repo. --public-url / $COMPASS_PUBLIC_URL supplies it; -// unset means empty, which the responder-assembly boot guard rejects for a -// deployment that consumes Linear webhooks, and which yields relative deep-link -// fragments for a socket-only local deploy.) - // errUsage marks a CLI usage error (a bad flag) that buildServeConfig's FlagSet // has ALREADY reported to stderr (usage + the parse error). run() returns it so // main() can exit non-zero without re-logging it through slog — a typo'd flag is