From c8154b987853e5739908a892ef603bb46e310460 Mon Sep 17 00:00:00 2001 From: Shisato Yano Date: Sat, 14 Nov 2026 15:46:10 +0900 Subject: [PATCH] =?UTF-8?q?docs:=20=F0=9F=93=9D=20Ask=20for=20images=20tha?= =?UTF-8?q?t=20show=20the=20result=20in=20pull=20requests?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The maintainer had to run each PR or open locally made images to see whether the code works. A PR template and Step 4 of HOWTOCONTRIBUTE.md now ask for the demo GIF of a new simulation, or before/after frames for a change under src/components/. The images can come from an older commit, so the review still runs the code and compares. Co-Authored-By: Claude Opus 5.5 --- .claude/skills/pr-review/SKILL.md | 5 +++-- .github/pull_request_template.md | 12 ++++++++++++ HOWTOCONTRIBUTE.md | 3 ++- 3 files changed, 17 insertions(+), 3 deletions(-) create mode 100644 .github/pull_request_template.md diff --git a/.claude/skills/pr-review/SKILL.md b/.claude/skills/pr-review/SKILL.md index 04c001b0..afe66ecf 100644 --- a/.claude/skills/pr-review/SKILL.md +++ b/.claude/skills/pr-review/SKILL.md @@ -18,7 +18,7 @@ Reviews a pull request against this project's conventions and its purpose as lea 1. Get the PR body, commits and changed files (`gh pr view --json body,commits,files,headRefOid`), and read the linked issue to see what was agreed with the maintainer 2. If the PR is stacked on other open PRs, review only the commits of this step (`git show `), since earlier steps are reviewed in their own PRs -3. If the body has images or videos (`https://github.com/user-attachments/assets/...` or `![...](...)`), tell the user they need to check them in the browser +3. If the body has images or videos (`https://github.com/user-attachments/assets/...` or `![...](...)`), tell the user they need to check them in the browser. If a type B or C PR (step 5) has none, ask for them in the draft, except in PRs opened before the PR template was added (2026-11-14) 4. When reviewing as the maintainer, if the PR has no label, assignee or reviewer yet, set the missing ones with `gh pr edit --add-label