From 34a733b17fc4ff42eb5b10a605eab823e88c97a8 Mon Sep 17 00:00:00 2001 From: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com> Date: Sun, 15 Nov 2026 15:51:46 +0400 Subject: [PATCH] fix(maths): ensure non-composite inputs are rejected in SmithNumber - Reject numbers <= 3 as Smith numbers must be composite (greater than 3) - Fix bug where isSmithNumber(0) incorrectly returned true - Prevent integer overflow in trial division loop condition by using (long) i * i - Add comprehensive test cases covering non-composite inputs (negative numbers, 0, 1), primes, and valid Smith numbers --- src/main/java/com/thealgorithms/maths/SmithNumber.java | 5 ++--- src/test/java/com/thealgorithms/maths/SmithNumberTest.java | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/SmithNumber.java b/src/main/java/com/thealgorithms/maths/SmithNumber.java index c06e0023d9bb..41d7bebed257 100644 --- a/src/main/java/com/thealgorithms/maths/SmithNumber.java +++ b/src/main/java/com/thealgorithms/maths/SmithNumber.java @@ -18,10 +18,9 @@ private SmithNumber() { private static int primeFactorDigitSum(int n) { int sum = 0; - int num = n; // Factorize the number using trial division - for (int i = 2; i * i <= num; i++) { + for (int i = 2; (long) i * i <= n; i++) { while (n % i == 0) { // while i divides n sum += SumOfDigits.sumOfDigits(i); // add sum of digits of factor n /= i; // divide n by the factor @@ -43,7 +42,7 @@ private static int primeFactorDigitSum(int n) { * @return {@code true} if {@code number} is a Smith number, otherwise false */ public static boolean isSmithNumber(int number) { - if (PrimeCheck.isPrime(number)) { + if (number <= 3 || PrimeCheck.isPrime(number)) { return false; // Smith numbers must be composite } diff --git a/src/test/java/com/thealgorithms/maths/SmithNumberTest.java b/src/test/java/com/thealgorithms/maths/SmithNumberTest.java index 4e2ba0b88e33..b073cda880fb 100644 --- a/src/test/java/com/thealgorithms/maths/SmithNumberTest.java +++ b/src/test/java/com/thealgorithms/maths/SmithNumberTest.java @@ -9,13 +9,13 @@ class SmithNumberTest { @ParameterizedTest - @CsvSource({"4", "22", "121", "562", "985", "4937775"}) + @CsvSource({"4", "22", "27", "58", "85", "94", "121", "562", "985", "4937775"}) void positiveSmithNumbersTest(int n) { assertTrue(SmithNumber.isSmithNumber(n)); } @ParameterizedTest - @CsvSource({"2", "11", "100", "550", "999", "1234557"}) + @CsvSource({"-22", "-4", "-1", "0", "1", "2", "3", "5", "6", "8", "9", "10", "11", "100", "550", "999", "1234557"}) void negativeSmithNumbersTest(int n) { assertFalse(SmithNumber.isSmithNumber(n)); }