From 5c93cf4f55e6cc2abccc44bb8e84c78a844622be Mon Sep 17 00:00:00 2001 From: Golrag Date: Thu, 3 Sep 2026 22:21:01 +0200 Subject: [PATCH 1/2] Fix SMSG_ENCOUNTER_START structure for 12.1.0 --- .../Parsers/InstanceHandler.cs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs index e892f22c6a..1e77225909 100644 --- a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs @@ -99,6 +99,10 @@ public static void ReadEncounterStartPlayerInfo(Packet packet, params object[] i packet.ReadInt32("Season", idx); packet.ReadInt32("Rating", idx); packet.ReadInt32("Tier", idx); + + if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_1_0_69214)) + TraitHandler.ReadTraitConfig(packet, idx, "TraitConfig"); + var itemInfoCount = packet.ReadUInt32(); for (var i = 0; i < statCount; i++) @@ -126,7 +130,8 @@ public static void ReadEncounterStartPlayerInfo(Packet packet, params object[] i ReadItemInfo(packet, idx, "ItemInfo", i); } - TraitHandler.ReadTraitConfig(packet, idx, "TraitConfig"); + if (!ClientVersion.AddedInVersion(ClientVersionBuild.V12_1_0_69214)) + TraitHandler.ReadTraitConfig(packet, idx, "TraitConfig"); packet.ResetBitReader(); var hasBFACharacterInfo = packet.ReadBit("HasBFACharacterInfo", idx); From 8b0312abb8aca84f444c928e3d9a7db53a1a8c89 Mon Sep 17 00:00:00 2001 From: Golrag Date: Thu, 3 Sep 2026 22:23:09 +0200 Subject: [PATCH 2/2] use RemovedInVersion --- WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs index 1e77225909..d2416f9c39 100644 --- a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs @@ -130,7 +130,7 @@ public static void ReadEncounterStartPlayerInfo(Packet packet, params object[] i ReadItemInfo(packet, idx, "ItemInfo", i); } - if (!ClientVersion.AddedInVersion(ClientVersionBuild.V12_1_0_69214)) + if (ClientVersion.RemovedInVersion(ClientVersionBuild.V12_1_0_69214)) TraitHandler.ReadTraitConfig(packet, idx, "TraitConfig"); packet.ResetBitReader();