From 2ea8e440996ee18b0bcb7c2eb9368021372f9a0a Mon Sep 17 00:00:00 2001 From: HURRAEY Date: Fri, 3 Jul 2026 14:44:14 +0900 Subject: [PATCH 1/3] fix(setSinkId): use requested sink for resource acquisition --- index.bs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/index.bs b/index.bs index d171a1232..99099c409 100644 --- a/index.bs +++ b/index.bs @@ -2275,11 +2275,13 @@ Methods associated {{AudioContext}}. 1. Attempt to acquire system resources to use - a following audio output device based on {{AudioContext/[[sink ID]]}} + the following output target based on |sinkId| for rendering: * The default audio output device for the empty string. - * A audio output device identified by {{AudioContext/[[sink ID]]}}. + * An audio output device identified by |sinkId|. + * No audio output device for an {{AudioSinkOptions}} whose + {{AudioSinkOptions/type}} is "{{AudioSinkType/none}}". In case of failure, reject |p| with "{{InvalidAccessError}}" abort the following steps. From 5c8ae1deda6b9e2a0c15341b7181b3df3d774236 Mon Sep 17 00:00:00 2001 From: HURRAEY Date: Fri, 3 Jul 2026 15:57:30 +0900 Subject: [PATCH 2/3] fix(pr-preview): allow existing Bikeshed messages --- .pr-preview.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pr-preview.json b/.pr-preview.json index 41eb56061..b92ae4671 100644 --- a/.pr-preview.json +++ b/.pr-preview.json @@ -2,6 +2,7 @@ "src_file": "index.bs", "type": "bikeshed", "params": { - "force": 1 + "force": 1, + "die-on": "nothing" } } From e2d489070326e818863dc780852016e3f8f0dc43 Mon Sep 17 00:00:00 2001 From: whizzkid1452 Date: Fri, 30 Oct 2026 08:49:52 +0900 Subject: [PATCH 3/3] fix: address sink resource acquisition review --- .pr-preview.json | 3 +-- index.bs | 6 ++++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.pr-preview.json b/.pr-preview.json index b92ae4671..41eb56061 100644 --- a/.pr-preview.json +++ b/.pr-preview.json @@ -2,7 +2,6 @@ "src_file": "index.bs", "type": "bikeshed", "params": { - "force": 1, - "die-on": "nothing" + "force": 1 } } diff --git a/index.bs b/index.bs index 99099c409..1d403ed78 100644 --- a/index.bs +++ b/index.bs @@ -1677,11 +1677,13 @@ Constructors named {{AudioContext/error}} at the {{AudioContext}}, and abort the following steps. - 1. Attempt to [=acquire system resources=] to use a following audio output device + 1. Attempt to [=acquire system resources=] to use the following output target based on {{AudioContext/[[sink ID at construction]]}} for rendering: * The default audio output device for the empty string. * An audio output device identified by {{AudioContext/[[sink ID at construction]]}}. + * No audio output device for an {{AudioSinkInfo}} whose + {{AudioSinkInfo/type}} is "{{AudioSinkType/none}}". 1. If resource acquisition fails, [=queue a media element task=] to [=fire an event=] named @@ -2283,7 +2285,7 @@ Methods * No audio output device for an {{AudioSinkOptions}} whose {{AudioSinkOptions/type}} is "{{AudioSinkType/none}}". - In case of failure, reject |p| with "{{InvalidAccessError}}" abort + In case of failure, reject |p| with "{{InvalidAccessError}}" and abort the following steps. 1.