From cf8421b91b580f9b79dbd1a1c55ce03d5a64f190 Mon Sep 17 00:00:00 2001 From: Omar Nahhas Sanchez Date: Wed, 5 Aug 2026 11:04:00 +0100 Subject: [PATCH] fix(ci): check out the devkit in upstream-compat, not just the plugin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit First real run failed on all four legs with context must be a directory: .../devcontainer The compat job checked out the plugin into plugin/ but never checked out the devkit itself, so devcontainer/Containerfile — which the harness build references relative to the workspace root — was simply not there. This is the exact path the author flagged as untested, since it differs from the proven plugin-e2e.yml body. Order matters: a checkout without `path` cleans the workspace, so the devkit must be fetched BEFORE the plugin is placed in plugin/, or it deletes it. Worth noting the design held: the report job FAILED loudly rather than reporting a vacuous pass, which is precisely the guard that DEC-079 nightly lacked. --- .github/workflows/upstream-compat.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/upstream-compat.yml b/.github/workflows/upstream-compat.yml index 457fe25..9ae5a40 100644 --- a/.github/workflows/upstream-compat.yml +++ b/.github/workflows/upstream-compat.yml @@ -170,6 +170,17 @@ jobs: permissions: contents: read steps: + # The devkit itself must land at the workspace ROOT: the harness build below + # references devcontainer/Containerfile relative to it. The first version of + # this job checked out only the plugin and every leg died with + # `context must be a directory: .../devcontainer` — the devkit was simply + # never fetched. + # + # Order matters. A checkout without `path` cleans the workspace, so it has to + # run BEFORE the plugin is placed in plugin/, or it would delete it. + - name: Checkout the devkit (harness + scripts) + uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 + - name: Checkout the plugin under test uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 with: