fix(@angular-devkit/schematics-cli): correctly parse inline boolean values in CLI options (#34201)

When CLI options defined as boolean are provided with inline values like '--debug=false' or '--dry-run=false', 'node:util.parseArgs' in non-strict mode returns string values ('false' / 'true') rather than booleans. This caused false values to be treated as truthy.

Normalize string boolean values in CLI options.

Closes #34199

PR Close #34201

Author: alan-agius4

packages/angular_devkit/schematics_cli/bin/schematics.ts

@@ -568,6 +568,15 @@ function parseOptions(args: string[]): Options {
     }
   }
 
+  for (const key of Object.keys(CLI_OPTION_DEFINITIONS)) {
+    const value = values[key];
+    if (value === 'true') {
+      values[key] = true;
+    } else if (value === 'false') {
+      values[key] = false;
+    }
+  }
+
   return {
     _: positionals,
     schematicOptions,

packages/angular_devkit/schematics_cli/test/schematics_spec.ts

@@ -59,6 +59,33 @@ describe('schematics-cli binary', () => {
     expect(res).toEqual(0);
   });
 
+  it('handles boolean CLI options with explicit inline false values', async () => {
+    const args = ['blank', 'foo', '--dry-run', '--debug=false'];
+    const res = await main({ args, stdout, stderr });
+    const output = stripVTControlCharacters(stdout.read()?.toString() || '');
+    expect(output).not.toMatch(/Debug mode enabled/);
+    expect(output).toMatch(/Dry run enabled\./);
+    expect(res).toEqual(0);
+  });
+
+  it('does not display help when --help=false is passed', async () => {
+    const args = ['blank', 'foo', '--dry-run', '--help=false'];
+    const res = await main({ args, stdout, stderr });
+    const output = stripVTControlCharacters(stdout.read()?.toString() || '');
+    expect(output).not.toMatch(/schematics \[collection-name:\]schematic-name/);
+    expect(output).toMatch(/Dry run enabled\./);
+    expect(res).toEqual(0);
+  });
+
+  it('does not list schematics when --list-schematics=false is passed', async () => {
+    const args = ['blank', 'foo', '--dry-run', '--list-schematics=false'];
+    const res = await main({ args, stdout, stderr });
+    const output = stripVTControlCharacters(stdout.read()?.toString() || '');
+    expect(output).not.toMatch(/blank/);
+    expect(output).toMatch(/Dry run enabled\./);
+    expect(res).toEqual(0);
+  });
+
   it('error when no name is provided', async () => {
     const args = ['blank'];
     const res = await main({ args, stdout, stderr });