From ff7e914eaea5a31e73fe2c242c217db081e48435 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Thu, 20 Aug 2026 16:18:12 -0400 Subject: [PATCH] chore: add missing `since` versions to `#[deprecated]` attributes The API health policy requires deprecated APIs to specify the DataFusion version they were deprecated in, so the removal clock can be evaluated. Five attributes on main had no `since`. Each version was determined from the release that first contained the commit which added the attribute. --- datafusion/core/src/physical_planner.rs | 4 ++-- datafusion/functions/src/string/overlay.rs | 1 + datafusion/optimizer/src/push_down_filter.rs | 2 +- datafusion/physical-plan/src/spill/spill_pool.rs | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/datafusion/core/src/physical_planner.rs b/datafusion/core/src/physical_planner.rs index bd1c29aa6d3e8..61da500734410 100644 --- a/datafusion/core/src/physical_planner.rs +++ b/datafusion/core/src/physical_planner.rs @@ -2560,7 +2560,7 @@ type AggregateExprWithOptionalArgs = ( ); /// Create an aggregate expression with a name from a logical expression -#[deprecated(note = "use LoweredAggregateBuilder")] +#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")] pub fn create_aggregate_expr_with_name_and_maybe_filter( e: &Expr, name: Option, @@ -2587,7 +2587,7 @@ pub fn create_aggregate_expr_with_name_and_maybe_filter( } /// Create an aggregate expression from a logical expression or an alias -#[deprecated(note = "use LoweredAggregateBuilder")] +#[deprecated(since = "54.0.0", note = "use LoweredAggregateBuilder")] pub fn create_aggregate_expr_and_maybe_filter( e: &Expr, logical_input_schema: &DFSchema, diff --git a/datafusion/functions/src/string/overlay.rs b/datafusion/functions/src/string/overlay.rs index 4a665dfde279c..4adb9cafcb21f 100644 --- a/datafusion/functions/src/string/overlay.rs +++ b/datafusion/functions/src/string/overlay.rs @@ -16,6 +16,7 @@ // under the License. #[deprecated( + since = "47.0.0", note = "overlay has been moved to core. Update imports to use core::overlay." )] pub use crate::core::overlay::*; diff --git a/datafusion/optimizer/src/push_down_filter.rs b/datafusion/optimizer/src/push_down_filter.rs index cf54ae254746d..8f72c1a8c311f 100644 --- a/datafusion/optimizer/src/push_down_filter.rs +++ b/datafusion/optimizer/src/push_down_filter.rs @@ -1343,7 +1343,7 @@ fn rewrite_projection( /// Creates a new LogicalPlan::Filter node. /// /// Deprecated: use [`Filter::try_new`] directly. -#[deprecated] +#[deprecated(since = "55.0.0", note = "Use `Filter::try_new` instead")] pub fn make_filter(predicate: Expr, input: Arc) -> Result { Filter::try_new(predicate, input).map(LogicalPlan::Filter) } diff --git a/datafusion/physical-plan/src/spill/spill_pool.rs b/datafusion/physical-plan/src/spill/spill_pool.rs index 6e964d7a6497b..63fedb5f3f930 100644 --- a/datafusion/physical-plan/src/spill/spill_pool.rs +++ b/datafusion/physical-plan/src/spill/spill_pool.rs @@ -476,7 +476,7 @@ pub fn spsc_channel( } /// Alias for [`mpsc_channel`]. -#[deprecated(note = "Use mpsc_channel instead")] +#[deprecated(since = "55.0.0", note = "Use mpsc_channel instead")] pub fn channel( max_file_size_bytes: usize, spill_manager: Arc,