From 214c916911f54dea278e2b3ce51be47f9185858f Mon Sep 17 00:00:00 2001
From: Raja-Hamid <rajahamidrazzaq24@gmail.com>
Date: Mon, 10 Aug 2026 18:57:47 +0500
Subject: [PATCH] refactor(frontend): remove two pieces of unreachable code

Both branches were shown by mutation testing to have no observable effect:
each mutation survived while the surrounding behaviour was under test.

- hugging-face-image-upload: the "Selected image" fallback rendered inside
  *ngIf="previewSrc", which is non-empty only when hasImage is true, and
  displayFileName already returns "Uploaded image" in exactly that case, so
  the right-hand side of the || could never be evaluated.
- drag-drop: the !jointLink guard was subsumed by the !linkView guard that
  follows it, since paper.findViewByModel(undefined) returns undefined
  rather than throwing.

Regression tests pin both behaviours -- the rendered preview label, and
skipping a link that exists in the Texera graph but has no model in the
JointJS paper -- and stay green across the removals.

Closes #7459
---
 .../hugging-face-image-upload.component.html  |  2 +-
 ...ugging-face-image-upload.component.spec.ts | 28 +++++++++++++++++++
 .../drag-drop/drag-drop.service.spec.ts       | 24 ++++++++++++++++
 .../service/drag-drop/drag-drop.service.ts    |  4 ---
 4 files changed, 53 insertions(+), 5 deletions(-)

diff --git a/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.html b/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.html
index 441c71f9c93..dbaa931295b 100644
--- a/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.html
+++ b/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.html
@@ -32,7 +32,7 @@
       [src]="previewSrc"
       alt="Uploaded Hugging Face task input" />
     <div class="hf-image-meta">
-      <span>{{ displayFileName || "Selected image" }}</span>
+      <span>{{ displayFileName }}</span>
       <button
         nz-button
         nzSize="small"
diff --git a/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.spec.ts b/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.spec.ts
index e22a4f5715a..71f5c92a9a7 100644
--- a/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.spec.ts
+++ b/frontend/src/app/workspace/component/hugging-face-image-upload/hugging-face-image-upload.component.spec.ts
@@ -199,6 +199,34 @@ describe("HuggingFaceImageUploadComponent", () => {
     });
   });
 
+  describe("rendered preview label", () => {
+    const previewLabel = () => fixture.nativeElement.querySelector(".hf-image-meta span") as HTMLElement | null;
+
+    it("labels the preview 'Uploaded image' when an image has no filename", () => {
+      component.formControl.setValue("data:image/jpeg;base64,AAA");
+      fixture.detectChanges();
+
+      expect(previewLabel()?.textContent?.trim()).toBe("Uploaded image");
+    });
+
+    it("labels the preview with the filename once one is known", () => {
+      component.formControl.setValue("data:image/jpeg;base64,AAA");
+      component.fileName = "cat.jpg";
+      fixture.detectChanges();
+
+      expect(previewLabel()?.textContent?.trim()).toBe("cat.jpg");
+    });
+
+    it("renders no preview at all without an image, so the label is never empty", () => {
+      // The preview only renders while previewSrc is non-empty, which happens exactly
+      // when hasImage is true — and displayFileName is never empty in that case.
+      component.formControl.setValue("");
+      fixture.detectChanges();
+
+      expect(previewLabel()).toBeNull();
+    });
+  });
+
   // ── Shared mocking helpers ──────────────────────────────────────────────
   // These helpers let us drive the private compressImage / renderCompressedDataUrl
   // pipeline end-to-end through onFileSelected.
diff --git a/frontend/src/app/workspace/service/drag-drop/drag-drop.service.spec.ts b/frontend/src/app/workspace/service/drag-drop/drag-drop.service.spec.ts
index 9642177890c..f76b0415567 100644
--- a/frontend/src/app/workspace/service/drag-drop/drag-drop.service.spec.ts
+++ b/frontend/src/app/workspace/service/drag-drop/drag-drop.service.spec.ts
@@ -467,6 +467,30 @@ describe("DragDropService", () => {
       expect(() => (dragDropService as any).clearEdgeIntersectionHighlight(link)).not.toThrow();
       expect((dragDropService as any).findIntersectedLink({ x: 0, y: 0 })).toBeNull();
     });
+
+    it("skips links that are in the Texera graph but have no model in the JointJS paper", () => {
+      const workflowActionService: WorkflowActionService = TestBed.inject(WorkflowActionService);
+      const paperHost = document.createElement("div");
+      document.body.appendChild(paperHost);
+      try {
+        workflowActionService.getJointGraphWrapper().attachMainJointPaper({ el: paperHost });
+        // findIntersectedLink walks the Texera graph but resolves each link against the
+        // JointJS paper, and the two can diverge. A link known only to Texera resolves to
+        // no joint model, so it must be skipped rather than dereferenced.
+        vi.spyOn(workflowActionService.getTexeraGraph(), "getAllLinks").mockReturnValue([
+          {
+            linkID: "ghost",
+            source: { operatorID: "op-a", portID: "op-a-output-0" },
+            target: { operatorID: "op-b", portID: "op-b-input-0" },
+          },
+        ] as OperatorLink[]);
+
+        expect(() => (dragDropService as any).findIntersectedLink({ x: 0, y: 0 })).not.toThrow();
+        expect((dragDropService as any).findIntersectedLink({ x: 0, y: 0 })).toBeNull();
+      } finally {
+        document.body.removeChild(paperHost);
+      }
+    });
   });
 
   describe("handleOperatorRecommendationOnDrag (drag lifecycle)", () => {
diff --git a/frontend/src/app/workspace/service/drag-drop/drag-drop.service.ts b/frontend/src/app/workspace/service/drag-drop/drag-drop.service.ts
index e7665582ba1..358f60664eb 100644
--- a/frontend/src/app/workspace/service/drag-drop/drag-drop.service.ts
+++ b/frontend/src/app/workspace/service/drag-drop/drag-drop.service.ts
@@ -440,10 +440,6 @@ export class DragDropService {
 
     for (const link of allLinks) {
       const jointLink = paper.getModelById(link.linkID) as joint.dia.Link;
-      if (!jointLink) {
-        continue;
-      }
-
       const linkView = paper.findViewByModel(jointLink) as joint.dia.LinkView;
       if (!linkView) {
         continue;