From 9a16849fc12638922989429251814f896b96260e Mon Sep 17 00:00:00 2001 From: Helias Date: Sat, 19 Sep 2026 18:15:43 +0200 Subject: [PATCH 1/3] ci: add core-build workflow --- .github/workflows/core-build.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/workflows/core-build.yml diff --git a/.github/workflows/core-build.yml b/.github/workflows/core-build.yml new file mode 100644 index 0000000..921c9eb --- /dev/null +++ b/.github/workflows/core-build.yml @@ -0,0 +1,12 @@ +name: core-build +on: + push: + branches: + - 'master' + pull_request: + +jobs: + build: + uses: azerothcore/reusable-workflows/.github/workflows/core_build_modules.yml@main + with: + module_repo: ${{ github.event.repository.name }} From 92efe240abd2034b64ef0beb68fabbf4579e5a16 Mon Sep 17 00:00:00 2001 From: Helias Date: Sat, 19 Sep 2026 21:55:13 +0200 Subject: [PATCH 2/3] test: remove unused helpers that break the build --- tests/unit/QrRendererTest.cpp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tests/unit/QrRendererTest.cpp b/tests/unit/QrRendererTest.cpp index 7df41d3..f30941c 100644 --- a/tests/unit/QrRendererTest.cpp +++ b/tests/unit/QrRendererTest.cpp @@ -63,18 +63,6 @@ namespace return geometry; } - std::string Dark(std::uint32_t widthPx, std::uint32_t heightPx, std::int32_t offY) - { - return std::string("|T") + DARK_TEXTURE + ":" + std::to_string(heightPx) + ":" + std::to_string(widthPx) + - ":0:" + std::to_string(offY) + ":" + DARK_COORDS + "|t"; - } - - std::string Light(std::uint32_t widthPx, std::uint32_t heightPx, std::int32_t offY) - { - return std::string("|T") + LIGHT_TEXTURE + ":" + std::to_string(heightPx) + ":" + std::to_string(widthPx) + - ":0:" + std::to_string(offY) + "|t"; - } - // Named for the pattern each one draws, top module first, so a mis-indexed style shows // up as the wrong path rather than as some other style's plausible-looking string. constexpr char const* PACK_LL = "Pack/LL"; From d2dbc233da772a9b850237ea06376cd8532fff6b Mon Sep 17 00:00:00 2001 From: Helias Date: Sun, 20 Sep 2026 10:27:22 +0200 Subject: [PATCH 3/3] test: do not hardcode the default quiet zone in the padded rows test --- tests/unit/QrRendererTest.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/unit/QrRendererTest.cpp b/tests/unit/QrRendererTest.cpp index f30941c..6ff6b18 100644 --- a/tests/unit/QrRendererTest.cpp +++ b/tests/unit/QrRendererTest.cpp @@ -301,11 +301,14 @@ TEST(QrRendererTest, ProducesOneLinePerPaddedRow) for (std::size_t i = 0; i < bitmap.modules.size(); ++i) bitmap.modules[i] = (i % 2) == 0; - QrRenderResult const result = RenderQr(bitmap, SquareGeometry()); + QrRenderGeometry const geometry = SquareGeometry(); + QrRenderResult const result = RenderQr(bitmap, geometry); + + std::size_t const paddedRows = bitmap.size + 2 * geometry.quietZone; ASSERT_EQ(QrRenderError::None, result.error); - EXPECT_EQ(std::size_t(29), SplitRows(result.text).size()); - EXPECT_EQ(std::size_t(28), std::count(result.text.begin(), result.text.end(), '\n')); + EXPECT_EQ(paddedRows, SplitRows(result.text).size()); + EXPECT_EQ(paddedRows - 1, std::size_t(std::count(result.text.begin(), result.text.end(), '\n'))); } /// The whole point of a palette: the colour reaches the dark modules and nothing else does.